Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1274368ybz;
        Wed, 22 Apr 2020 17:23:08 -0700 (PDT)
X-Google-Smtp-Source: APiQypKQDEhfiaP5Doa+UBuU968VxiW7X891F7wR9ohwKaeLh6Y+tKeJJttiTCtHqif2wd1SpBaU
X-Received: by 2002:aa7:d4d3:: with SMTP id t19mr863547edr.144.1587601388274;
        Wed, 22 Apr 2020 17:23:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587601388; cv=none;
        d=google.com; s=arc-20160816;
        b=dBLbOe80F/9BxuE+V3nSsAt9VcutrtE9pjO80GWKS6kBhc4Mn/GG/mL9mVZf3iw63k
         w0B0IpZf+7KPIqufSFY2v2eBdqofUwmYAJl3nooPq4jOrBXbUSY/v7vLUXvxnCQ1ZqVS
         r2jQ5NMHiyf8Vqg+PztSwhEhOVkgDsAI+qtB03fnYd/lWb9nm8yBxE18gvTFc9xRjM+5
         Ni0qC8AU9zr+IgdvmtomjRPFgvvP99ULvtBIdMbOUtwzma9nJ28IUs+uMVivGVnYOx2m
         1sUlzPAO2FhHQmC9Oepk0O1855+gM1MQWcQctL4qMQd4jwgWK8G8qmjagT9Db7qVJBgb
         v2mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=ybUhgqqgDgpDb0C0l9CPAGBHtiAuRZLMLq6/0nshfDs=;
        b=quJXWm0oqsUBanWF+4EJ54dQoaciJ2PJaaD2ea8uYrMKGt9c9Cei3vjImAMo5g9v/K
         C2EypiFjf/jlaRf+MUenhGYoBTNiEX0XBlf7z+fEKODHqbhEfqmV9RI8fEpIq4F4H0Bg
         cuhvbLVNw9Q8J9U/bsyWSVGDkBzhcqP2VzDgJKdc5hIs5u4Gdtz7f64ywmp/cENhg1Ra
         AIMensmix4Uer9Wjb7bIPfrLFWEyuO4EfwLY04wyKSWiGxKecd56MO6zMlDyxKvaneVE
         XeMgE3cs7REJfajh6SqQn0XIe51fRYx2xTr88CmUwJj9PI3koPJfP++lw7M50hriBGUd
         wfeg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Xc9xahHP;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id gz10si364685ejb.167.2020.04.22.17.22.45;
        Wed, 22 Apr 2020 17:23:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Xc9xahHP;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726061AbgDWAVw (ORCPT <rfc822;proy.cse@gmail.com> + 99 others);
        Wed, 22 Apr 2020 20:21:52 -0400
Received: from mail.kernel.org ([198.145.29.99]:60992 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725846AbgDWAVv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Apr 2020 20:21:51 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 3BB9D20704;
        Thu, 23 Apr 2020 00:21:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1587601311;
        bh=ic4v7Bk99U/2TTEq7gGalaOGjQfJ77Qj/nZpBQvFafs=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Xc9xahHPbLcSTN9pbScT2pW9xqYT8eG4za17xS7KW0hqL5f8ky+TvyRUlzYD7UDxK
         9mC40qyTljL+k3WCcuv0KpkXtpcQKlpln6tpk4EeuutnkIte5xANP2nXsSiU/CMa0p
         hZUQL6dJAZIQGCam4N+q19C2SKnoqbTcRLE3yagA=
Date:   Wed, 22 Apr 2020 17:21:49 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     khalasa@piap.pl, davem@davemloft.net, linus.walleij@linaro.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH v2] net: ethernet: ixp4xx: Add error handling in
 ixp4xx_eth_probe()
Message-ID: <20200422172149.787fdc3c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200422010922.17728-1-tangbin@cmss.chinamobile.com>
References: <20200422010922.17728-1-tangbin@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 22 Apr 2020 09:09:22 +0800 Tang Bin wrote:
> The function ixp4xx_eth_probe() does not perform sufficient error
> checking after executing devm_ioremap_resource(), which can result
> in crashes if a critical error path is encountered.
> 
> Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")
> 

No extra lines, between the tags, though, please.

> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>