Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1365649ybz; Wed, 22 Apr 2020 19:42:08 -0700 (PDT) X-Google-Smtp-Source: APiQypLf2lNSuSU/LBBVYnbCxSorDFQjqxKMyF57HoATIYWCAzQOm4TjnyoXPU6zbRYALemuAx9L X-Received: by 2002:a17:906:468c:: with SMTP id a12mr1003199ejr.149.1587609728231; Wed, 22 Apr 2020 19:42:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587609728; cv=none; d=google.com; s=arc-20160816; b=o/NJaBrVC86H/cuYTHXQYS01WDNlA5Lka8qtLybKj87mupz3jX3GcQ1yGpWLagagwU 8jZtv5tAexke7YB8jkAZ/z9j8mPlw2Meg/NiZYE6f68Rfk+nAXi9ZHIqscGewnm22+Re dgMezHbPNQ4PLnbc5YOk/+6yils8P4CIA1yL++9F/FL+r474pTi9cDY8LzH/5DApfkCA XBkSTz7k6l7nnSwG/wad0mhBAwGN19XHEqumVqydHYf3x9waU47WI1anweiuU+gqYU6e DSF9xmy8IHPqdOUx1umiZTPUqsOlIDiSBdU51jwzOrPwSEkAjSBmrPHaGwDsghldDTew u9OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=NoxGIZVZc+LppbZoBMmQU68AZHVDfRa+LTdyJuFlIUg=; b=M1aPhN9Odh+qxTNcEU36WnnHGOx3ZA+CXp0BSZQmNSS29ExShhQfnSvmSPf4eHHNqD v+ot8+J8uCfMnA0ATaxkD3qbJPiwMzpdHu19Q98bh2ko3/kicmG+lSAjI25b2VEfptly QzPb1cqav4G0itgDzzGhaXvx1Lgz4KqpF+k9QmvKp3gDLBJ5InCuvQYeFx8ecfTWJAde szkwVTlxKkZGa4sST60bWnHJ+t/+OO8LHrHHCWfWLCVnuA9pzvUYluR46i5emWz+vHkM aSURhQ14/csIw/EhdQyy2UWJTyBIFqkGACUM2Ha2+JHWnjet5323riRTC479MB3J49RD T7QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do8si663765ejc.149.2020.04.22.19.41.45; Wed, 22 Apr 2020 19:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgDWCkU (ORCPT + 99 others); Wed, 22 Apr 2020 22:40:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbgDWCkU (ORCPT ); Wed, 22 Apr 2020 22:40:20 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2C20C03C1AB; Wed, 22 Apr 2020 19:40:20 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 25EBD127AD655; Wed, 22 Apr 2020 19:40:20 -0700 (PDT) Date: Wed, 22 Apr 2020 19:40:19 -0700 (PDT) Message-Id: <20200422.194019.686324336801344834.davem@davemloft.net> To: tangbin@cmss.chinamobile.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH] net: phy: Use IS_ERR() to check and simplify code From: David Miller In-Reply-To: <20200422081542.8344-1-tangbin@cmss.chinamobile.com> References: <20200422081542.8344-1-tangbin@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Apr 2020 19:40:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin Date: Wed, 22 Apr 2020 16:15:42 +0800 > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant paramenter definitions > and judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied, thanks.