Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1365766ybz; Wed, 22 Apr 2020 19:42:21 -0700 (PDT) X-Google-Smtp-Source: APiQypI2Cl2ebvIZ3wURXqJE8eY5O9bY0pOStWAWY/WyG+wTxDkGNre4cRAsJIbQBVlfE3Psi+eC X-Received: by 2002:a17:906:1292:: with SMTP id k18mr981227ejb.132.1587609741595; Wed, 22 Apr 2020 19:42:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587609741; cv=none; d=google.com; s=arc-20160816; b=j9avhupFB2j1WKR5zJfqnVeteaehVPj7RmodG8xEmrunPMi5VV0od/VmmlREhhRod/ uTEGrL8LuVtYWGY73uxY3tnRCCxXhlXQxCcLbVCOn0FO0wPbVmiUNv32ipXpSZuKbnet FNT5UHr0Dql+TtrF9Zio7dM5Cttz87dqiHPLpJU65SLIC2NsfeZa8wtgFgUI5Gnj6JOL 8M1/r0+FYtPfLF6UqH1MBt2GaQWTbEAEZJUY5Ypaq1NL266K51BlDrbEgkB7+MVudjey d3va/FwDUf+QzVafytggEnMdSRBfA6it55zXrkiiHOehwu23ChelVP5lDcaCMkGhIpxF AJOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+uG6EAR12GRVcQB/HOeD/bcxj8EbFRMvdBi1b8aObDk=; b=NG8AeQykPOoRC0blxSQ+3+2u6XMODJCa+vOr+ti7hjiiWA417ERyLjqcHtP8CGmuRw QH1tl6qXeRQ521msrs5cT7HFlhgZ7XBFwXXprlVqgebBRWarFGfcOLH570ZlN3k4RyRQ CFM34+N1TWxlrTijO5EnnYTSgLJyDvSK+STa5xtfl6tsCCtIR2VPa7iSF/SiEN7LNbMa /Mu1t4YlHyvUOpbfQuYIzOf6k+GGiRL7JxMmBx10AqoDwkx1dk7X7kDBQrqXr1oofvjR OFLSUVMxCvOC7K2JpKMHUIYxsP/dFrnkZkWcX27IKOZrz6OSgLMG57EwYm+OEJvGxnE9 J1uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si538441ejw.505.2020.04.22.19.41.59; Wed, 22 Apr 2020 19:42:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgDWCjI (ORCPT + 99 others); Wed, 22 Apr 2020 22:39:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbgDWCjI (ORCPT ); Wed, 22 Apr 2020 22:39:08 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706FCC03C1AB; Wed, 22 Apr 2020 19:39:08 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A1880127AD655; Wed, 22 Apr 2020 19:39:07 -0700 (PDT) Date: Wed, 22 Apr 2020 19:39:07 -0700 (PDT) Message-Id: <20200422.193907.1128604166633852958.davem@davemloft.net> To: o.rempel@pengutronix.de Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, david@protonic.nl, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, philippe.schenker@toradex.com, linux@armlinux.org.uk Subject: Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY From: David Miller In-Reply-To: <20200422072137.8517-1-o.rempel@pengutronix.de> References: <20200422072137.8517-1-o.rempel@pengutronix.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Apr 2020 19:39:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleksij Rempel Date: Wed, 22 Apr 2020 09:21:37 +0200 > Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, rgmii-rxid. > > This PHY has an internal RX delay of 1.2ns and no delay for TX. > > The pad skew registers allow to set the total TX delay to max 1.38ns and > the total RX delay to max of 2.58ns (configurable 1.38ns + build in > 1.2ns) and a minimal delay of 0ns. > > According to the RGMII v1.3 specification the delay provided by PCB traces > should be between 1.5ns and 2.0ns. The RGMII v2.0 allows to provide this > delay by MAC or PHY. So, we configure this PHY to the best values we can > get by this HW: TX delay to 1.38ns (max supported value) and RX delay to > 1.80ns (best calculated delay) > > The phy-modes can still be fine tuned/overwritten by *-skew-ps > device tree properties described in: > Documentation/devicetree/bindings/net/micrel-ksz90x1.txt > > Signed-off-by: Oleksij Rempel Applied, thank you.