Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1587609160-117806-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1587609160-117806-1-git-send-email-zou_wei@huawei.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 22 Apr 2020 21:32:31 -0700
Message-ID: <CAEf4BzaMEsmLmoJKk67DazZ1-GHSiOLcB7nB9Yh8N8wAViG0eg@mail.gmail.com>
Subject: Re: [PATCH -next] bpf: Make bpf_link_fops static
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
        Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
        john fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 22, 2020 at 7:27 PM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> kernel/bpf/syscall.c:2289:30: warning: symbol 'bpf_link_fops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---

Thanks!

Acked-by: Andrii Nakryiko <andriin@fb.com>

>  kernel/bpf/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 8608d6e..fcb80e1 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -2286,7 +2286,7 @@ static void bpf_link_show_fdinfo(struct seq_file *m, struct file *filp)
>  }
>  #endif
>
> -const struct file_operations bpf_link_fops = {
> +static const struct file_operations bpf_link_fops = {
>  #ifdef CONFIG_PROC_FS
>         .show_fdinfo    = bpf_link_show_fdinfo,
>  #endif
> --
> 2.6.2
>