Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1458854ybz; Wed, 22 Apr 2020 22:15:37 -0700 (PDT) X-Google-Smtp-Source: APiQypLbgKrWfjH91pDWFp9DahFSJSU5D0IzjqN4zHBqyZWJVXDGcyfg2K80J5thx94ERDTsRNH4 X-Received: by 2002:a50:8e01:: with SMTP id 1mr1356307edw.26.1587618936856; Wed, 22 Apr 2020 22:15:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587618936; cv=none; d=google.com; s=arc-20160816; b=rI7VVJ+FCxIs7scWqWdhKAzJpcyQBxYUUnCJ4PwLWoh6XRELwjcip/w1T804mrJJN8 RKWWf8QTYySFm5avEC3WQRVpS4pw9cxotVsroBhGBRRCF18vOywzSZnFGlGrsWDbfOLV J2OIUxnxnFzh+XQAHuhFXGDD5QhIuFEVK2qSuvWAcUUBfEJzd8bITy7bXMXT7o1FMf7h UhlWRPG4olExa7/HHK6ndawq9maN3Hgq4ZtKeh2D89qsGDeMbTc5fRyxN+SkOrdGr9VT qsgC9gDz+MaVBbF1uo9hlmcNd3G1ePF+L5mY3XtNiGhrrYgrf2F9EhCKsL3MIvprGkIK wGYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=GQOse9hB0t+K70/jnTnd98X5m9YT3pNtskCYHmrUrF8=; b=jfaTbwUs71xd/e5taMN0k2p28SFxdiHkVpt7BlSqTlxL8Sa/irub+cKKGShP2w4CWb hZO4ZzAKfNnlIJJThWkSyn8EiIn9yFPAAdeNnUYt4/0yNztGB/3jy+Ythli0FmWiq1SK axzO21dsCn1AEWdVRr625qDNZEyNPIObxIMNNCcY+u2YDSg+jcnMikpQiCtF1GRFrHFq TbkObCW7K1Yc7sYxMcZgZOknVDIz3vZAwjDxxYndoxymzFncGSHF8BVNN1PWaNLuW/kr qy0uQZCTpdppG4jwidJQPuoLmR4TqheQyCyUzwySsFoEytF1RVtrNloTVh4OO9hXmngg 0SWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j2si691032ejs.138.2020.04.22.22.15.14; Wed, 22 Apr 2020 22:15:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726602AbgDWFLI (ORCPT + 99 others); Thu, 23 Apr 2020 01:11:08 -0400 Received: from foss.arm.com ([217.140.110.172]:60418 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbgDWFLI (ORCPT ); Thu, 23 Apr 2020 01:11:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42B421FB; Wed, 22 Apr 2020 22:11:07 -0700 (PDT) Received: from [10.163.1.9] (unknown [10.163.1.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60FD33F6CF; Wed, 22 Apr 2020 22:10:56 -0700 (PDT) Subject: Re: [PATCH V3 0/3] arm64: Enable vmemmap mapping from device memory To: linux-mm@kvack.org Cc: robin.murphy@arm.com, dan.j.williams@intel.com, jglisse@redhat.com, jgg@mellanox.com, rcampbell@nvidia.com, aneesh.kumar@linux.ibm.com, Catalin Marinas , Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Tony Luck , Fenghua Yu , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , David Hildenbrand , Mike Rapoport , Michal Hocko , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Andrew Morton , Pavel Tatashin , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <1585631387-18819-1-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Thu, 23 Apr 2020 10:40:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1585631387-18819-1-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/31/2020 10:39 AM, Anshuman Khandual wrote: > This series enables vmemmap backing memory allocation from device memory > ranges on arm64. But before that, it enables vmemmap_populate_basepages() > and vmemmap_alloc_block_buf() to accommodate struct vmem_altmap based > alocation requests. > > This series applies after latest (v14) arm64 memory hot remove series > (https://lkml.org/lkml/2020/3/3/1746) on Linux 5.6. > > Pending Question: > > altmap_alloc_block_buf() does not have any other remaining users in the > tree after this change. Should it be converted into a static function and > it's declaration be dropped from the header (include/linux/mm.h). Avoided > doing so because I was not sure if there are any off-tree users or not. > > Changes in V3: > > - Dropped comment from free_hotplug_page_range() per Robin > - Modified comment in unmap_hotplug_range() per Robin > - Enabled altmap support in vmemmap_alloc_block_buf() per Robin Just a gentle ping. Any updates on this series ? In particular, is there any comments or suggestions or concerns with respect to the first two patches here that change the core MM and relevant call sites on some platforms. Thank you. - Anshuman