Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1500315ybz; Wed, 22 Apr 2020 23:21:19 -0700 (PDT) X-Google-Smtp-Source: APiQypJENJF6wXXjSDrpKZNVvQ6fCHTB7DYaSwbOMd4Bd3FcifTUpHRApcSIHHGvIA+SlIJsrelz X-Received: by 2002:a17:906:3296:: with SMTP id 22mr1459405ejw.195.1587622879466; Wed, 22 Apr 2020 23:21:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587622879; cv=none; d=google.com; s=arc-20160816; b=S1LiTIUA91WbIaI9ladhWmQ/mOfCEW9ycRfCeMXIfPnN6+BniXzhtN+6f5U8Cd4V3o kYvDDsJjg0wbRuyZi6LxosZu6efY2f/c0dYp2fLQ1Kv8eBUMCWfbeA2+mZQdHebmjcz9 Wv0AkWPFvRuk7PqqQcnvjrI41V4QaLftQW77WoVwCVbX4pWupBlVPoebl2D3ry0d5LyN mO28EBsgAfVvznZF+PVoCAxxPwf2a5BOEXYqFFpukywpYBICi1U1Z2MGO6zBc9cNvj4J QilKUQLX+MmUEx/7+P28zBXbsUqOi923vXLkXI1vC7ZbYMcGVz5acf8sd+S3NZjuabzT PQmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+YN5bZu+giSm6zx69sHuKvMXTwcSygih7gxkx+qmMxc=; b=tevWKiwJ6iUm2Q6YryEnpQJrmvvEhSZ0FTpSA2qG1HJd5vncrjIvLurL0I5jOwTFwW YKG8i9eWScJ4KRa8YHRqILR5mz7/XYM55wGFFkZgYYw9GPMCVO7G4KFSTVFpFDuFTl8O ES2/m08F5FB65weG7x0FxnF2dFujrAkedwA9HplIwAM4o5jz0FQpKPpUDz9UOJIgetq+ 8QuFnBCoVgzMWf87eOTVs+yWx3txDgiz138ca+8BMTimkFHle6dVetidpQYeXcgS4YUA pANSIflsCZImtn7hqN/HFxRMlfZ0qWgma35Q/j0i+Brdpf6HOaw3dWv6ro4mEFdPAOkr B17w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cICEJ7bT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cd11si686637ejb.435.2020.04.22.23.20.55; Wed, 22 Apr 2020 23:21:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cICEJ7bT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726358AbgDWGTk (ORCPT + 99 others); Thu, 23 Apr 2020 02:19:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:37160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgDWGTk (ORCPT ); Thu, 23 Apr 2020 02:19:40 -0400 Received: from localhost (unknown [49.207.59.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FEE920724; Thu, 23 Apr 2020 06:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587622780; bh=iFjJ7P8tBt9jHw5u95JP/ux+NUoop1lg0l7BJRMhoB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cICEJ7bT3GN1L4+ipzn26G1bBSKBzZkqsDQKXBSIaQEJnTkROEOozheAlJxp+NaCE BjyzuOFtZXd3jSUsW+ZAC5lAv0QZjIMf0LaCP1+f0/F1cQJqdWe2UH/7Ok5Ynshqjc 9XMxUTVgT9BGMCusZTVu5t0kD50JmTSx4+UM/4zk= Date: Thu, 23 Apr 2020 11:49:35 +0530 From: Vinod Koul To: madhuparnabhowmik10@gmail.com Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, andrianov@ispras.ru, ldv-project@linuxtesting.org Subject: Re: [PATCH] drivers: dma: pch_dma.c: Avoid data race between probe and irq handler Message-ID: <20200423061935.GV72691@vkoul-mobl> References: <20200416062335.29223-1-madhuparnabhowmik10@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416062335.29223-1-madhuparnabhowmik10@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-04-20, 11:53, madhuparnabhowmik10@gmail.com wrote: > From: Madhuparna Bhowmik > > pd->dma.dev is read in irq handler pd_irq(). > However, it is set to pdev->dev after request_irq(). > Therefore, set pd->dma.dev to pdev->dev before request_irq() to > avoid data race between pch_dma_probe() and pd_irq(). Please use the right subsystem tag for patch. You can find that using git log on the respective subsystem, in this case it would have told you that it is dmaengine. I have fixed that up and applied it, thanks for the patch -- ~Vinod