Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1527501ybz; Thu, 23 Apr 2020 00:03:15 -0700 (PDT) X-Google-Smtp-Source: APiQypIQX/KIvJ1ckKh4NYJI8HpUJ7OFhHpHZIlsypq2Z6xNs7EN+MkjFT7fMk59aU9GZcvn9GbS X-Received: by 2002:a05:6402:1717:: with SMTP id y23mr939073edu.361.1587625394908; Thu, 23 Apr 2020 00:03:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587625394; cv=none; d=google.com; s=arc-20160816; b=tNtyyuLAGB7lBgn6lFYvmeqY9EOTOVZYLoBoXIHdL0QGM5HGcSYwIRRtpODDE9SFt+ iSkplegKG35VRA7Y/0CC2a2T6vgGliK8i9idH0DSDccVy4gpeEKVCN/6iPqdKDQN43mR mP/eoSkX5S473w0MCDD3kCIx7yAnKGIHS3wIOpg536t8TSWg6UT+KgUP19Iu+R+/efz8 DUnWei428ZX/7oOTT1ndcJPS2D9cPfphC2zZrSgADoKQC5RViyRJmmj1OZ1qjcOzOtsM tQ6f23tGG+mTTz6Y8j3JG6ROzc5Dz+qAIm4JYb4k25is8ZVE280FBISpKpX3MBAiXHle D4FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature; bh=jnGBvqgD2+rCZ5dqwcs/N0/DjWzyVn5656ZJjEr5E6M=; b=n/w/7HqaZBGZe7fRKOm6iSGbMDQ/s/WKQ1opUwSvY/K2al8OOfVUr2Hr5JdDWGHeIx 0bOVnU3X5EkU7bSFEtFqKoFf2K/S58+xDBf5XuqaSvNgXgVnOOBwXbKx4eoGTEo5BWjk X+X+O6GVwI5vMvV1R4phNLUOXkEgYBqo24i4era+NJa98Ozr3V5sAgCs8MPMTDvrtvc3 ddtn6vPRyGCkJG1f+OGAqdyUQGV5wOdOyAeCX4wRHHRq8pH0GCtEoP49vvkUJtuPpvHt 98wMIjp1zwlFCKWZM/oLV7pMNwce5gcukpD4nyablM9QVZlSStMjnUX1VZHMVttvRd9p CjQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Mc74Mtgk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si741116edv.549.2020.04.23.00.02.51; Thu, 23 Apr 2020 00:03:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=Mc74Mtgk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbgDWHBY (ORCPT + 99 others); Thu, 23 Apr 2020 03:01:24 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:40180 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbgDWHBX (ORCPT ); Thu, 23 Apr 2020 03:01:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587625283; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=jnGBvqgD2+rCZ5dqwcs/N0/DjWzyVn5656ZJjEr5E6M=; b=Mc74MtgkK7HuKMOFeFopLWMbyVa9Gz6/PsoMuZ0vHTPpW4zb+bkUfzmKH5FsH4w3fp66K6jw 2XDv2cVVlsJ6BP7BURebssQx3Vr8FljouGWEAJGjz6SBYkGLCxmDvdOgP4t4xFsKr4hqpZdd 4MEaZd6K43fOGocHUK4QFt6bD+Q= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea13d35.7f87b6312490-smtp-out-n02; Thu, 23 Apr 2020 07:01:09 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C0E57C433F2; Thu, 23 Apr 2020 07:01:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 917ACC433D2; Thu, 23 Apr 2020 07:01:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 917ACC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Kai-Heng Feng Cc: Tony Chuang , "David S. Miller" , "open list\:REALTEK WIRELESS DRIVER \(rtw88\)" , "open list\:NETWORKING DRIVERS" , open list Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context References: <20200423063811.2636-1-kai.heng.feng@canonical.com> <20200423063811.2636-2-kai.heng.feng@canonical.com> <87h7xan1cy.fsf@kamboji.qca.qualcomm.com> Date: Thu, 23 Apr 2020 10:01:03 +0300 In-Reply-To: (Kai-Heng Feng's message of "Thu, 23 Apr 2020 14:53:18 +0800") Message-ID: <87d07yn0sw.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kai-Heng Feng writes: >> On Apr 23, 2020, at 14:49, Kalle Valo wrote: >> >> Kai-Heng Feng writes: >> >>> It's incorrect to use usleep in atomic context. >>> >>> Switch to a macro which uses udelay instead of usleep to prevent the issue. >>> >>> Signed-off-by: Kai-Heng Feng >> >> This fixes a regression, right? So there should be a Fixes line. > > Yes, but the regression commit isn't in Linus' tree, so the sha1 may change. No, the commit id won't change after I have commited the patch. I don't rebase my trees. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches