Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Zou Wei <zou_wei@huawei.com>, Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH -next] qed: Make ll2_cbs static
Thread-Topic: [EXT] [PATCH -next] qed: Make ll2_cbs static
Thread-Index: AQHWGT/gNMC0p00KAUeahMVFzzJqUqiGU0mg
Date:   Thu, 23 Apr 2020 07:44:02 +0000
Message-ID: <MN2PR18MB318279E835EF6483CE55304DA1D30@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <1587626860-97801-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1587626860-97801-1-git-send-email-zou_wei@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ad42ec5-217d-42e6-7417-08d7e75a17cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 07:44:02.7687
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Qx4VFkkgrX+ekdtqMEC+LSwN/3s6ZP/RnOKtv3sGE90JSQKFfwT+ebpGwVzWEBOWWdDlYNv0FPRpBJIq7ibz3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2366
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-23_06:2020-04-22,2020-04-23 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Zou Wei <zou_wei@huawei.com>
> Sent: Thursday, April 23, 2020 10:28 AM
>=20
> ----------------------------------------------------------------------
> Fix the following sparse warning:
>=20
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:2334:20: warning: symbol 'll2_c=
bs'
> was not declared. Should it be static?
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_ll2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> index 037e597..4afd857 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
> @@ -2331,7 +2331,7 @@ static void qed_ll2_register_cb_ops(struct qed_dev
> *cdev,
>  	cdev->ll2->cb_cookie =3D cookie;
>  }
>=20
> -struct qed_ll2_cbs ll2_cbs =3D {
> +static struct qed_ll2_cbs ll2_cbs =3D {
>  	.rx_comp_cb =3D &qed_ll2b_complete_rx_packet,
>  	.rx_release_cb =3D &qed_ll2b_release_rx_packet,
>  	.tx_comp_cb =3D &qed_ll2b_complete_tx_packet,
> --
> 2.6.2

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>