Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1564009ybz; Thu, 23 Apr 2020 01:00:21 -0700 (PDT) X-Google-Smtp-Source: APiQypJvi0xsvzh4s87hrAISOl8cUkYM8lEXZbph7gMhVW2PEoVJyuKKr0YO29MeAGI6FYhjV4ci X-Received: by 2002:a17:906:bce4:: with SMTP id op4mr1530427ejb.174.1587628821260; Thu, 23 Apr 2020 01:00:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587628821; cv=none; d=google.com; s=arc-20160816; b=n6n3zqK/L4KgkKvZ08LIUTrfUsGr0bOA8bsMuTt0X+srtCTfGheVp251qCXJ0xq1Ee 2F+ZgoPu3yOfgWI+rNCQU9h94GbPkOK93RHAWSoF2pXf2eC2l6jyjZgCDnzKjeBO1k28 Gi4z4Dp8DDMwbiEpd4IEoeoGiv2p/GXjQYPRpmLAvPI5BGxvhPu0Vymspat2Gu9xfubL ixqn19lmi6Y8QmgJItVtVjxApr+n54123anIdCVuG0TNmP+7o9e4arD2QqXb+wGpi5P6 yTZaZAUk54MgPp3yFFHM+BIDEZ9XJEhX5jqpLZpcwHhIGamWE5pfg2Q8FipoQn1T037p JeFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=DQN4EvPH/0gI6Xjlhug7z4MrgssR3UoZFk0z+dSqw4Q=; b=TwzLJn3DG/YVSY0URkkSdnRhBJEO3Aiej/hlZtcn/3jP+7HN4vueRwfYapimlVycDe gXEcnckIb9M1fNmz3BAG/wtD28hNIlUoU/SF7pHS5WY4imZGVnmuJZHHoYh92yfbOJ7z KuBDFL0ipRwiIaK8ln8twQmPA7HdSPaZNudiIUOCKEpJEjfiZ1dIx5SihJLZtLMWArE+ g2diEgnWrXA2eOxETgQnKKg388TFNvnXFgAnH0S0AYT5wiOA3aNnNQgrPRH9U8US3e8v Nz77e4+0sfI1SOPi82r/4C0RWF9xzeFzJjF9y4PTRs+iIgj7VSHAa6w2B6+v9dz6TEwV YMUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a11si723199edv.573.2020.04.23.00.59.57; Thu, 23 Apr 2020 01:00:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbgDWH6c (ORCPT + 99 others); Thu, 23 Apr 2020 03:58:32 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:42943 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgDWH6c (ORCPT ); Thu, 23 Apr 2020 03:58:32 -0400 Received: from localhost.localdomain ([93.23.15.131]) by mwinf5d85 with ME id W7yS2200m2pfeyd037yTwC; Thu, 23 Apr 2020 09:58:29 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Thu, 23 Apr 2020 09:58:29 +0200 X-ME-IP: 93.23.15.131 From: Christophe JAILLET To: stas.yakovlev@gmail.com, kvalo@codeaurora.org, davem@davemloft.net Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] ipw2x00: Remove a memory allocation failure log message Date: Thu, 23 Apr 2020 09:58:25 +0200 Message-Id: <20200423075825.18206-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Axe a memory allocation failure log message. This message is useless and incorrect (vmalloc is not used here for the memory allocation) This has been like that since the very beginning of this driver in commit 43f66a6ce8da ("Add ipw2200 wireless driver.") Signed-off-by: Christophe JAILLET --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 60b5e08dd6df..30c4f041f565 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -3770,10 +3770,9 @@ static int ipw_queue_tx_init(struct ipw_priv *priv, struct pci_dev *dev = priv->pci_dev; q->txb = kmalloc_array(count, sizeof(q->txb[0]), GFP_KERNEL); - if (!q->txb) { - IPW_ERROR("vmalloc for auxiliary BD structures failed\n"); + if (!q->txb) return -ENOMEM; - } + q->bd = pci_alloc_consistent(dev, sizeof(q->bd[0]) * count, &q->q.dma_addr); -- 2.20.1