Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1612630ybz; Thu, 23 Apr 2020 02:13:20 -0700 (PDT) X-Google-Smtp-Source: APiQypJNIbqsysCeCIxdi7d4T0M+nZAVyIpqy8SY1j3DylZnRvczmyT1QigmsF/VD95Esc7bsEi4 X-Received: by 2002:a17:906:1584:: with SMTP id k4mr1910038ejd.355.1587633200099; Thu, 23 Apr 2020 02:13:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587633200; cv=none; d=google.com; s=arc-20160816; b=FpWDVpKhHB/4Gt2LhNWZv69aC4vvrgwNH4jjslCkIuJOl4TfaZLbmaYvB7CW+rQpg0 p90XdZ/RyRGwJcxr8/X3YSGp2no7ead2nDCQWXKB7ic+TICuCfJ+6LY0dQi9IHyAoZUQ 98bm/fqRcXg9rwxQ11ULevGfUdb6Z/W4mUgc3FuUWIijODmk9vZ/Tze6G0MKRSPKSl2s YJJmaSfenI0dfej3iLa/sfOQlVYQgRJ1zhAeNbRsKyMmQ0PNFiVVTmVfen2lkxUDOTFV LXGCzE0IxBc6BosB06fa6vSoj5tOCusIojvKHYdcIWWrZekNcqZ8bge1gC/T2qt3JxTI pJng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=DgtDjVPta5yQkPVz+2jZ9BxsN0H3oPXTkKDVd+s09cQ=; b=gDVZW7QL3Ir6iV/SpWV/VKMHsm3AMypfJr/oDnIENGzk2Jv/XBKc4GtYk3DjhBpKfE YSM3dzphsLpvmFnvikykyn09hg7h+VwjvPmWWYKUJqyfjOtOs6lqqVk1i5NAGvI3ru/7 vQGHV2k0nJoWoii11gTxfN5ItL/FoCiU2ECbRGEu4rEi1Dy0ecVhQ8JI99bLzJBBYOn5 1iCIPV2gd/tKqamFdAZPqFiRd6mcXnuoiTEKNbYJ/8dWWTf/Ty4lYs3eEo7VNV4TO+xE H4iEv4dqCOQGqaZVpKyaHlM0dwN0ZX+eRyyqd/4Tqzj1nx547duuHwXHbW/wLgv7jluQ tIJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m2si869599ejk.483.2020.04.23.02.12.56; Thu, 23 Apr 2020 02:13:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgDWJJT (ORCPT + 99 others); Thu, 23 Apr 2020 05:09:19 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2878 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725884AbgDWJJS (ORCPT ); Thu, 23 Apr 2020 05:09:18 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9496F9BBF6822CF50185; Thu, 23 Apr 2020 17:09:11 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 23 Apr 2020 17:09:01 +0800 From: Zou Wei To: CC: , , Zou Wei Subject: [PATCH -next] mmc: core: Use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE Date: Thu, 23 Apr 2020 17:15:19 +0800 Message-ID: <1587633319-19835-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes coccicheck warning: drivers/mmc/core/debugfs.c:222:0-23: WARNING: mmc_clock_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files Fixes: 703aae3d09a4b ("mmc: add a file to debugfs for changing host clock at runtime") Fixes: a04c50aaa916f ("mmc: core: no need to check return value of debugfs_create functions") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/mmc/core/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c index 09e0c76..9ec84c8 100644 --- a/drivers/mmc/core/debugfs.c +++ b/drivers/mmc/core/debugfs.c @@ -219,7 +219,7 @@ static int mmc_clock_opt_set(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, +DEFINE_DEBUGFS_ATTRIBUTE(mmc_clock_fops, mmc_clock_opt_get, mmc_clock_opt_set, "%llu\n"); void mmc_add_host_debugfs(struct mmc_host *host) @@ -232,8 +232,8 @@ void mmc_add_host_debugfs(struct mmc_host *host) debugfs_create_file("ios", S_IRUSR, root, host, &mmc_ios_fops); debugfs_create_x32("caps", S_IRUSR, root, &host->caps); debugfs_create_x32("caps2", S_IRUSR, root, &host->caps2); - debugfs_create_file("clock", S_IRUSR | S_IWUSR, root, host, - &mmc_clock_fops); + debugfs_create_file_unsafe("clock", S_IRUSR | S_IWUSR, root, host, + &mmc_clock_fops); #ifdef CONFIG_FAIL_MMC_REQUEST if (fail_request) -- 2.6.2