Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Apr 2020 13:34:39 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc:     Suraj Upadhyay <usuraj35@gmail.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: wfx: cleanup long lines in data_tx.c
Message-ID: <20200423103439.GN2659@kadam>
References: <20200422153900.GA6184@blackclown>
 <2253201.upfRyW1aZW@pc-42>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2253201.upfRyW1aZW@pc-42>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 23, 2020 at 09:29:28AM +0000, Jerome Pouiller wrote:
> >         req->data_flags.fc_offset = offset;
> >         if (tx_info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM)
> >                 req->data_flags.after_dtim = 1;
> > @@ -517,7 +523,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif, const struct hif_cnf_tx *arg)
> >                 if (tx_count < rate->count &&
> >                     arg->status == HIF_STATUS_RETRY_EXCEEDED &&
> >                     arg->ack_failures)
> > -                       dev_dbg(wvif->wdev->dev, "all retries were not consumed: %d != %d\n",
> > +                       dev_dbg(wvif->wdev->dev,
> > +                               "all retries were not consumed: %d != %d\n",
> 
> Is this reported by checkpatch? The strings can exceed 80 columns.
> 

The string can go over 80 characters, but it's nice to do our best to
avoid it so we do normally break it up like this where the string is
on its own line.

regards,
dan carpenter