Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "rafael@kernel.org" <rafael@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "S.j. Wang" <shengjiu.wang@nxp.com>
Subject: RE: [PATCH] regmap: mmio: prepare/unprepare clk only when read/write
Thread-Topic: [PATCH] regmap: mmio: prepare/unprepare clk only when read/write
Thread-Index: AQHWGTO9B+V6d2Mrk0mLlfc3ryCDK6iGhKwAgAACseA=
Date:   Thu, 23 Apr 2020 10:51:36 +0000
Message-ID: <DB6PR0402MB27600084E4A040609EF620A088D30@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <1587620791-5279-1-git-send-email-peng.fan@nxp.com>
 <20200423104000.GD4808@sirena.org.uk>
In-Reply-To: <20200423104000.GD4808@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 63766426-514b-406e-40c6-08d7e7744b91
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 10:51:36.4368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Xv9ziboUo/Lmdv+/aLH477C4hWUv7+T/VnkoOoWmOmxLUjEPKN2nTY/qyoiT+PL2yRV4qLuybvFvt244ZoOKEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2757
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] regmap: mmio: prepare/unprepare clk only when
> read/write
>=20
> On Thu, Apr 23, 2020 at 01:46:31PM +0800, peng.fan@nxp.com wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > use clk_prepare at the very beginning will invoke pm runtime resume,
> > if the clk is binded with a power domain. This will cause runtime
> > power high. Let's use clk_prepare_enable and clk_disable_unprepare
> > when read/write to avoid the runtime power issue.
>=20
> This will mean that we're doing clk_prepare() during I/O which isn't good
> since for MMIO regmaps we support I/O operations in atomic contexts.

Ah, yes. Do you have any suggestions? If we use clk_prepare at the very
beginning, the power that binded to the clk device will be always on,
and cause power consumption high.

Thanks,
Peng.