Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Apr 2020 12:22:44 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "rafael@kernel.org" <rafael@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "S.j. Wang" <shengjiu.wang@nxp.com>
Subject: Re: [PATCH] regmap: mmio: prepare/unprepare clk only when read/write
Message-ID: <20200423112244.GH4808@sirena.org.uk>
References: <1587620791-5279-1-git-send-email-peng.fan@nxp.com>
 <20200423104000.GD4808@sirena.org.uk>
 <DB6PR0402MB27600084E4A040609EF620A088D30@DB6PR0402MB2760.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0OWHXb1mYLuhj1Ox"
Content-Disposition: inline
In-Reply-To: <DB6PR0402MB27600084E4A040609EF620A088D30@DB6PR0402MB2760.eurprd04.prod.outlook.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--0OWHXb1mYLuhj1Ox
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 23, 2020 at 10:51:36AM +0000, Peng Fan wrote:

> > This will mean that we're doing clk_prepare() during I/O which isn't good
> > since for MMIO regmaps we support I/O operations in atomic contexts.

> Ah, yes. Do you have any suggestions? If we use clk_prepare at the very
> beginning, the power that binded to the clk device will be always on,
> and cause power consumption high.

Not really in regmap itself - I think your best bet here is to move the
clock handling out of regmap and up into the driver.  regmap won't do
any I/O unless your driver calls it so this will work fine, this support
is only there in regmap as a convenience but if it's getting in the way
then you're probably going to be able to do a better job pushing this
into rutime PM in the driver or just having direct clock calls.

--0OWHXb1mYLuhj1Ox
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6heoQACgkQJNaLcl1U
h9CBywf/fnPhJcXY/ZcsnQ/vi7O9VXPKIUEMsFAKUwu8ovYZddm/l6F8UyHMsiC4
F2UqvKs2OQYkgFaYlFPX1Iz7/6mIh6tP/GvG62CtvCj4a1cBfnORs0bz9+N9fbiS
ZPvPAkToWzpV46b11jtFNkipWF/B0/9R5p6DDmA67GkLp8lTTotLqEKPg1aAMWHr
6oyxAIE/wE+j0ZSbueHwMInY2ZDZ8tMetzOw2AEx9VIKyWq36iSXu1u+B0MVlzzR
Wh/4GDgenCPocGtQLUpsjnIKP3Md2VdEShpziIDHTZd3FTW7swo582KksFKOK/jq
NjoDzT5amhMVYNtmsTdgyAZ/E2vxig==
=Krch
-----END PGP SIGNATURE-----

--0OWHXb1mYLuhj1Ox--