Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1737930ybz; Thu, 23 Apr 2020 05:00:02 -0700 (PDT) X-Google-Smtp-Source: APiQypL4q9jvz7kU0Gye4GdsgVlYwOPJ2z/3AFYKmlsr6E/xqw9a2sy4FIG7Vum5HdNOtm9ToIRn X-Received: by 2002:a05:6402:b03:: with SMTP id bm3mr2234292edb.299.1587643202328; Thu, 23 Apr 2020 05:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587643202; cv=none; d=google.com; s=arc-20160816; b=ZzRXRBTuF+Vt8o0P+NI7AMMok06W2LvrjfTRuOpybfqA6foxY/KfOP97m/gXcHPVcI /HCfoQaXKEAi8AmuhN86VOpFBxVcrCWvfbD6TSaFnTaTYa+cjqaQgBpAkaxafKxwBAxq xaBlcdEjpwSbYKcYjsJFIgjdEEmIwLGcndPZvKYzeMdEBNb0rEMITZOzB9oWWfbgxdHP JYZE+AFYXlBW7KMrJ8mGmzkmzlmr0tWYsKo3JEj+jvbJPBIxXXFoK7781+5EhGwMI4dx IFKFZT6jyw1FEZJNuRz2mg65nA3SKbJfye/5RCwzVvW7hDOnDG36tWf+dURBFUmLP+sS yRRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=22K7e5bi+qDNTIa3H9RAfgmRH6jNmYZQ+Im8eu78c0c=; b=EuJgXw8DNBvplO/0Srkj511o//02k9jOTvu2xSolO+F+uUB74UaczIDM/gkvwy13m2 xpjaVUoF3MlN0Ij46kqzgPu5CBo4WDfO454gV144eVOLYrdEPb2cynrYpwGIpHP1/nuh ICEzfXwm1q/f0pZXkw44cmSQ/CZdpYUqotUCGVnsQ1WfXyY8Jk1nMYER9stpLmISXfxF NBgkEyFCTG1m3JNun3EGFVY6awkrpP3np4EN1d7iv0F5hMo+yOAkMUKSyXYPpiO7NaJm atyri4Wn6FwAz5yZp6fc+ME3mYKO/rbYs9ipwfWcCtKvMUMqpfa9zFLUKbEzrhrr5ruJ gJ7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sBJms3bp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si87615eds.361.2020.04.23.04.59.39; Thu, 23 Apr 2020 05:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sBJms3bp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgDWLkf (ORCPT + 99 others); Thu, 23 Apr 2020 07:40:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:52532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727903AbgDWLkf (ORCPT ); Thu, 23 Apr 2020 07:40:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 716EC2084D; Thu, 23 Apr 2020 11:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587642034; bh=v+cZbNEq+8xq9TdljfKBzmW0OSxSI3Wv8ELxe4MyXrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sBJms3bpeviFauiUcUCQiOq4YvvYk8OFWsy6Mp3B3HOj2vHhfIUOdLNK6VE7XTw/v 0ouOwtoiVcQZBwXoRq0gVUDPF5lCTPzp00Kx+NssOTIojVr14VSLr5B6qEeEIXo/Co PVQZ5gxk+pxMcaBUiQjn3KKxoZiOVne9eWvObe4I= Date: Thu, 23 Apr 2020 13:40:32 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , Quentin Deslandes , Malcolm Priestley , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls Message-ID: <20200423114032.GA3838948@kroah.com> References: <20200419104821.6127-1-oscar.carter@gmx.com> <20200419104821.6127-2-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200419104821.6127-2-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2020 at 12:48:20PM +0200, Oscar Carter wrote: > Check the return value of vnt_control_out_* function calls. When > necessary modify the function prototype to be able to return the new > checked error code. > > It's safe to modify all the function prototypes without fix the call > because the only change is the return value from void to int. If before > the call didn't check the return value, now neither. > > Signed-off-by: Oscar Carter This patch, and the 2/2 patch did not apply to my tree. Can you please rebase and resend? thanks, greg k-h