Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Apr 2020 09:17:44 -0300
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Ralph Campbell <rcampbell@nvidia.com>
Cc:     nouveau@lists.freedesktop.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jerome Glisse <jglisse@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Christoph Hellwig <hch@lst.de>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] nouveau/hmm: fix nouveau_dmem_chunk allocations
Message-ID: <20200423121744.GY11945@mellanox.com>
References: <20200421231107.30958-1-rcampbell@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200421231107.30958-1-rcampbell@nvidia.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (142.68.57.212) by MN2PR05CA0040.namprd05.prod.outlook.com (2603:10b6:208:236::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.7 via Frontend Transport; Thu, 23 Apr 2020 12:17:48 +0000
Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1)     (envelope-from <jgg@mellanox.com>)      id 1jRanY-0000Yz-Mh; Thu, 23 Apr 2020 09:17:44 -0300
X-Originating-IP: [142.68.57.212]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: eeadbf96-dc79-4c79-8fe0-08d7e780561d
X-MS-TrafficTypeDiagnostic: VI1PR05MB5309:
X-Microsoft-Antispam-PRVS: <VI1PR05MB5309B847A35EA2EEC76F2366CFD30@VI1PR05MB5309.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-Forefront-PRVS: 03827AF76E
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB4141.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(396003)(376002)(366004)(136003)(346002)(478600001)(2616005)(36756003)(26005)(6916009)(54906003)(316002)(9746002)(8936002)(52116002)(33656002)(9786002)(1076003)(4326008)(186003)(8676002)(2906002)(86362001)(66556008)(66946007)(81156014)(4744005)(66476007)(5660300002)(24400500001);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aKcP5yubRMascTm+4jBG2c1VCBne/enCht7uTYQn5/Sv029hAR12RbpL93sx6qRxjdItreNysQW1MfkUsSatUfKSP+PWMgeNTXuc7YQ6oe5cLWHx5twxvEGAKARpeG2rHTPqeulMO6/N/jNShCpo9vgeYcvEyXZEFiUD6oB0ImqmeGvY7s3wT/gBtKMjTQ+ap6+YARkyyNT8cmEmosanmJfD6dv1BjJnni/iJXliAzmzV/2Bz8IpA/DuMJ5KlvnQNRyS2KuFdWbPPij+0hb/qjso6trEnQDLCwI+vAO1cfy0fMALVaCuazdgYXaNdn5xGcPIQanUTMu4qj/Bh0tn5kb/tiiNthpx6E1dCSAdNTJGFUBb9YnfUVXF/xmRbuVkAOPWsnbVhFbj/L6aDXLSlXN61UZ/vQ4PiEHDydsQPc31fehPn5GUAooEJx9+10r0fcazIhjEI/bKEfAjbagPmHUalgj8yAw2ujm+yQZKN/JvH7JA3gOt0qHUXGTdsG6h
X-MS-Exchange-AntiSpam-MessageData: lvOkdB4WXtBGXgfBQVAHdAWyjTKJed3l/FQfOnEGDwXrjbkx+KtG4e+gxLO91YuSM08pmM/EoZ+2anRmdof74fN0ygvsZ8bQyOp/3ZxngIUiqdLvKqAaa7vmGiX/h6qJdLcEgGcUvNjuxxwxmUR9SA==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eeadbf96-dc79-4c79-8fe0-08d7e780561d
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2020 12:17:48.4621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WKL/A2P4WVUBu71hpNLnkmFrKlUM36EzPzX/hP3/YA5tuTlTYnQtFRLIn6GL7cp/mavcWkWj3bycvUguVQGeLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5309
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 21, 2020 at 04:11:07PM -0700, Ralph Campbell wrote:
> In nouveau_dmem_init(), a number of struct nouveau_dmem_chunk are allocated
> and put on the dmem->chunk_empty list. Then in nouveau_dmem_pages_alloc(),
> a nouveau_dmem_chunk is removed from the list and GPU memory is allocated.
> However, the nouveau_dmem_chunk is never removed from the chunk_empty
> list nor placed on the chunk_free or chunk_full lists. This results
> in only one chunk ever being actually used (2MB) and quickly leads to
> migration to device private memory failures.
> 
> Fix this by having just one list of free device private pages and if no
> pages are free, allocate a chunk of device private pages and GPU memory.
> 
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_dmem.c | 304 +++++++++----------------
>  1 file changed, 112 insertions(+), 192 deletions(-)

Does this generate any conflicts with my series to rework
hmm_range_fault?

Jason