Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1870818ybz; Thu, 23 Apr 2020 07:28:28 -0700 (PDT) X-Google-Smtp-Source: APiQypLau6S4EJiM/8WUkKEVMayX80Utl/h1actLevqOZQLPZ/+vJukPTZqcxO7GeqjDHNDE/CP+ X-Received: by 2002:a17:906:55c4:: with SMTP id z4mr2838625ejp.353.1587652108615; Thu, 23 Apr 2020 07:28:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587652108; cv=none; d=google.com; s=arc-20160816; b=nGV/uZgf/AHRDuJ3j+oCwt9Kd2BVgqkbuNACjwQ7n77ow2y02Oh5fv0DTFLJI0VHmB FYUB5zW6PgNsGi7puWM1HRFueZjbPYbCSHTfkazu0t6eqOFhnfO06ZFl2VsRpjvbQCaN jyLILiavI3VaEfGVBDaM9UGgVPyMXS/PzO+0TIpuvngqAXqZFVdC/bcXcaPBKIYiUdrT qaHMWTvLtPBPovo2UrqIs57hZQ58EGpDlfNraMa5mpq0cZqBy0M8npcWZpiRaEo11vYB ygaPsmzRtbul2bJp8i2okhC+cz7PBnuhA/hnKeMDutqXH92U5YqFwhXrC7naLlQ8KswS RC5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=On7uMVKUj/oaJJmzywZSm4qsJXQIiJn8ZPz+oC8CTSE=; b=r14B7VqCv3DA1yKfUJhV7juWsu5+BuckCjDHfmtnFm33ajrPxhqBsTEUI2r+u9TQ/E spsBTFqWXinTO4Et4Pox3VR0kL3a+mhNt1mbVcNke/Zqhyc1YoeGNUAa8J7upGJUwCPQ uTdEPkEtGKrWWBI+ZhESkaxhNsACIcVSM6rClEEKMShhmqsY6nevIjAsN06fR5LII1am iF2V2Y4jM6b5aXg9PcctQVNyQ5GT5GQyIHLucUW9N3Bn54z77KahkX65Ic3pVdpkLxhj ChQHxJDhvCBb8IGnLZCXIPpK3tU3CSYfWnj1x/D5Jkl6ExrNxt2gJC/WdBUyzL1u/xDm 0LSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Q5C1V4io; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h11si1184855edr.106.2020.04.23.07.28.05; Thu, 23 Apr 2020 07:28:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Q5C1V4io; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728013AbgDWOYK (ORCPT + 99 others); Thu, 23 Apr 2020 10:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726591AbgDWOYJ (ORCPT ); Thu, 23 Apr 2020 10:24:09 -0400 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3440DC08E934 for ; Thu, 23 Apr 2020 07:24:09 -0700 (PDT) Received: by mail-yb1-xb42.google.com with SMTP id n188so3238276ybc.3 for ; Thu, 23 Apr 2020 07:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=On7uMVKUj/oaJJmzywZSm4qsJXQIiJn8ZPz+oC8CTSE=; b=Q5C1V4ioZfi/+MM9yv6Cv+SHFjYnL3VOcPKr1mZvDos2T8v85hmBSffk983k5JwUNp ANH21Hh0gwip6XnY++G5HwcFbasNi1n6OdSzCpkenzz1a6owgSmSe8cxdphujeM2vykV Pal5Y/9qt0e52WqVq4sQ8UuxOpsNp+SC8Scy2O6zAn+RiQS0iuwx9KlxJa3+kLt+kGqR 3G8BXu2X6ProAyhn5Uu3T+pMoJdnPcs9mHiH3FupB/jAS5BZbXAdokizLf0MtkbcYtpz u6j8RLg8FbjhQrcMQlQ2/fGDeiM4yuEEkuPTabRH076SXZC0lsDYhnoJgx9i+oPliUqE 9n1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=On7uMVKUj/oaJJmzywZSm4qsJXQIiJn8ZPz+oC8CTSE=; b=MDS5wLADcX0XC+SVX5/Rd74Jo9xnh5B+xhOuLWruQQ5jjh73/HQvkr85R+ITxNy47D pUhqRGZ9IPRZx0FvSpI59UPZGVMFleZSzkyDBEErZ28DEdb3cZ2f3P0VyD/4YQrZZNaP 0rPvMWT2r9Wa81w1Jvd54F7QkPfYMWhbjs+O4Tj6wzz0kR+SUkQ5h5+rFWJpLdu1i0Zx WrfVeDMWyt642+DRTamqTwSFEuS7axO7NU/IUAFheon9fyOS8fgEEneUdvHtZqOtTqr+ PT7jGeMgd/3W0dJpVUj8/c40JqvXKZqXocm+PuRzNHmThc/RQk9zowinRE0LH/RSQNwa GifQ== X-Gm-Message-State: AGi0PuZAzDHwv3IIEsrrDnLvoFExn2AHPoj9KeIRGZh+oLJGIpFA1Sx8 oXF3oCp9CHb4406dwAne6X30vjWBDmtbZpS8t4SVsA== X-Received: by 2002:a25:77d8:: with SMTP id s207mr7227599ybc.47.1587651848118; Thu, 23 Apr 2020 07:24:08 -0700 (PDT) MIME-Version: 1.0 References: <20200422220430.254014-1-irogers@google.com> <20200422220430.254014-6-irogers@google.com> <20200423112915.GH1136647@krava> In-Reply-To: <20200423112915.GH1136647@krava> From: Ian Rogers Date: Thu, 23 Apr 2020 07:23:56 -0700 Message-ID: Subject: Re: [PATCH v2 05/11] perf expr: increase max other To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Kan Liang , Andi Kleen , Haiyan Song , Jin Yao , Song Liu , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , Paul Clarke , LKML , linux-perf-users , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 23, 2020 at 4:29 AM Jiri Olsa wrote: > > On Wed, Apr 22, 2020 at 03:04:24PM -0700, Ian Rogers wrote: > > Large metrics such as Branch_Misprediction_Cost_SMT on x86 broadwell > > need more space. > > > > Signed-off-by: Ian Rogers > > --- > > tools/perf/util/expr.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h > > index 0938ad166ece..4938bfc608b7 100644 > > --- a/tools/perf/util/expr.h > > +++ b/tools/perf/util/expr.h > > @@ -2,7 +2,7 @@ > > #ifndef PARSE_CTX_H > > #define PARSE_CTX_H 1 > > > > -#define EXPR_MAX_OTHER 20 > > +#define EXPR_MAX_OTHER 64 > > #define MAX_PARSE_ID EXPR_MAX_OTHER > > > > struct expr_parse_id { > > -- > > 2.26.2.303.gf8c07b1a785-goog > > > > ok, and we should probably start to think about what Andi suggested > in here: https://lore.kernel.org/lkml/20200224210308.GQ160988@tassilo.jf.intel.com/ Agreed, a hash table would make sense. This was the smallest value that would let the test on x86 pass. Thanks, Ian > jirka >