Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbWCDUdo (ORCPT ); Sat, 4 Mar 2006 15:33:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751527AbWCDUdo (ORCPT ); Sat, 4 Mar 2006 15:33:44 -0500 Received: from smtp.osdl.org ([65.172.181.4]:42171 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751516AbWCDUdn (ORCPT ); Sat, 4 Mar 2006 15:33:43 -0500 Date: Sat, 4 Mar 2006 12:28:48 -0800 From: Andrew Morton To: Nick Piggin Cc: zippel@linux-m68k.org, torvalds@osdl.org, bunk@stusta.de, geert@linux-m68k.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.16-rc regression: m68k CONFIG_RMW_INSNS=n compile broken Message-Id: <20060304122848.188430e8.akpm@osdl.org> In-Reply-To: <4409A05F.2090704@yahoo.com.au> References: <20060303230149.GB9295@stusta.de> <20060303155913.2e299736.akpm@osdl.org> <4409A05F.2090704@yahoo.com.au> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 30 Nick Piggin wrote: > > Roman Zippel wrote: > > Hi, > > > > On Fri, 3 Mar 2006, Andrew Morton wrote: > > > > > >>Yes, we now require cmpxchg of all architectures. > > > > > > Actually I'd prefer if we used atomic_cmpxchg() instead. > > The cmpxchg() emulation was never added for a good reason - to keep code > > from assuming it can be used it for userspace synchronisation. Using an > > atomic_t here would probably get at least some attention. > > > > Yes, I guess that's what Andrew meant. The reason we can require > atomic_cmpxchg of all architectures is because it is only guaranteed > to work on atomic_t. > > Glad to hear it won't be a problem for you though. > Could someone with an m68k compiler please send the patch? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/