Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1911041ybz; Thu, 23 Apr 2020 08:11:51 -0700 (PDT) X-Google-Smtp-Source: APiQypJ8DrcC4UocDWsBWkDNV93Zej9fws6Y712d3DPOt0v2SZXjmdK7mS5p2zztaFU5Xkh9279h X-Received: by 2002:a17:906:1490:: with SMTP id x16mr2792462ejc.323.1587654711678; Thu, 23 Apr 2020 08:11:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587654711; cv=none; d=google.com; s=arc-20160816; b=nyOWakMJw0/vedfV3hfKp21aFZw1iY+ck0F+7DO8EMsdgXxERwCzzk5WTYssYIJ7GN Xl2u29PG8umtVMXkgH1I54LNSHK7E+IKYtJRvVyY+g/JlOTJ0nqFzKANcKze3uCZVQGQ 58Gqd88Bg1dobxTA8aFBkwq4adE+yCQau0BklC9D+21oLMrZ7SQT9N86N9neCmH0qpVU +6jOzq1foPibxN/9B7uT2quk68oR3JwBzLHkDmws/DyTKKMZy43rOvMWAfIFlqvW2gJU 48CfN3W3k9PgWL2IGBhpkotxPEGx52NkSiF0lQ3HGrf0XUd8E6fqXgbXRm33Fg9YVABQ U0xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zc2RuJG+E2+4TamJRI8Bv/UYisP7AVTkwnNZjUmbgck=; b=TQUP/ccsnwZ9vDvIrQbd/gFnfOGzv5FPjp+UwGZR7z771WBisTM6kW0n6WGRXLryVz 36cSRCEXw47iSyFAC5ahqtwxLbdno6cVOQe80LceLCRwGrF2SP6igo/xY1yr78t4mRwS L/IGjwK0FTUJ63p4aSiDezUfxPF0YMQfcpHeGaglKHDF1m39IgeBz2mc7rxMqIKQwhK9 170/VgaO44dKEZCzszppwlzIAyvGxcz6S0TwcJMzPaFbL7q+Fi/uk9IC+z7RJ9b38aN+ ivmm7mZDZQYx3c/q4sUrypi7t7+kX5t+IB61fMTfa49KqIYzJ/UtetinLZC8JUkoYFa9 TFvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="W9Z2Sq4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m4si1443855eje.107.2020.04.23.08.10.26; Thu, 23 Apr 2020 08:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="W9Z2Sq4/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgDWPF7 (ORCPT + 99 others); Thu, 23 Apr 2020 11:05:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728878AbgDWPF7 (ORCPT ); Thu, 23 Apr 2020 11:05:59 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08945C09B040 for ; Thu, 23 Apr 2020 08:05:59 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id w18so3026164qvs.3 for ; Thu, 23 Apr 2020 08:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zc2RuJG+E2+4TamJRI8Bv/UYisP7AVTkwnNZjUmbgck=; b=W9Z2Sq4/1SQQqjT4ehzpodampIzNO11tWTR2bOJ5Scxv7AoliJfPHi6YEJJzz2u/B+ BJOCWEFn7b1OwSecxvRATeV2vfj74grYnlYtbgDT3D2O2Ik/pvxDgUnoMSknT9diq8hm fw5Nv/O2M8WKsUmp4k5JgRQY9U0TwL4t8eUR0MhvJo0L4O5WE85ck4BTCrjxBNs2ec3m Lq5qvMNOwcQyuPky1TXPtT6/kFhuwjSHzh8SQTEcytYtSsSw4eb2IDtuqFDv5X4tI16P alF+8PnqZgPdaJubC0iDV/pQkk1OdPkAi1SYRdxZyctq0Squpr23MmtOucFrJuXBgMHr KlYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zc2RuJG+E2+4TamJRI8Bv/UYisP7AVTkwnNZjUmbgck=; b=eMwmL53+ZZywAVs4u58E3z5d36nMazuJbBXudTyNBE0vEPZtbp/2olE0/mursLzRCJ IkL8j5oYpVNNZ6LZ7qBzinIED6+rhzZDkYyfCS8c1vNP1cQ6O8E42IEpvG6oKxh0V7lF tE8pApY4n2tvvwU/dFlAjt6UK2sOQ1O3hsD+qi8JzXKd4sRUvLtrScGerSz+wyD4OTnO u3ylPO6hqLyuLfSVEonozhwdQ4XuWUm5IbcdMDA9ip4z9dPQlmOG3K3HsojYtrT3sOyI jNrA9lwLI4SYIqXMXAIZr7nPuisSwbn6ORAoRznvWq3mrXP38wnLRvEu2cPc4YudMnVX 0ZxA== X-Gm-Message-State: AGi0Pubj5C5UFar1QHORGGm/FK4vSOCKyf+EwFWcJzVdEQRb91M2sMf4 k4dLBH4Sp5V0fAyE7rzGphHBvg== X-Received: by 2002:ad4:44ab:: with SMTP id n11mr4639727qvt.235.1587654358068; Thu, 23 Apr 2020 08:05:58 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id p24sm1910939qtp.59.2020.04.23.08.05.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Apr 2020 08:05:57 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jRdQL-0003UI-0h; Thu, 23 Apr 2020 12:05:57 -0300 Date: Thu, 23 Apr 2020 12:05:57 -0300 From: Jason Gunthorpe To: Nicolas Pitre Cc: Randy Dunlap , Jani Nikula , Saeed Mahameed , "masahiroy@kernel.org" , "Laurent.pinchart@ideasonboard.com" , "airlied@linux.ie" , "linux-kbuild@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jernej.skrabec@siol.net" , "arnd@arndb.de" , "netdev@vger.kernel.org" , "jonas@kwiboo.se" , "kieran.bingham+renesas@ideasonboard.com" , "narmstrong@baylibre.com" , "leon@kernel.org" Subject: Re: [RFC PATCH 1/2] Kconfig: Introduce "uses" keyword Message-ID: <20200423150556.GZ26002@ziepe.ca> References: <87v9lu1ra6.fsf@intel.com> <45b9efec57b2e250e8e39b3b203eb8cee10cb6e8.camel@mellanox.com> <62a51b2e5425a3cca4f7a66e2795b957f237b2da.camel@mellanox.com> <871rofdhtg.fsf@intel.com> <940d3add-4d12-56ed-617a-8b3bf8ef3a0f@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 23, 2020 at 11:01:40AM -0400, Nicolas Pitre wrote: > On Wed, 22 Apr 2020, Randy Dunlap wrote: > > > On 4/22/20 2:13 PM, Nicolas Pitre wrote: > > > On Wed, 22 Apr 2020, Jani Nikula wrote: > > > > > >> On Tue, 21 Apr 2020, Nicolas Pitre wrote: > > >>> This is really a conditional dependency. That's all this is about. > > >>> So why not simply making it so rather than fooling ourselves? All that > > >>> is required is an extension that would allow: > > >>> > > >>> depends on (expression) if (expression) > > >>> > > >>> This construct should be obvious even without reading the doc, is > > >>> already used extensively for other things already, and is flexible > > >>> enough to cover all sort of cases in addition to this particular one. > > >> > > >> Okay, you convinced me. Now you only need to convince whoever is doing > > >> the actual work of implementing this stuff. ;) > > > > > > What about this: > > > > > > Subject: [PATCH] kconfig: allow for conditional dependencies > > > > > > This might appear to be a strange concept, but sometimes we want > > > a dependency to be conditionally applied. One such case is currently > > > expressed with: > > > > > > depends on FOO || !FOO > > > > > > This pattern is strange enough to give one's pause. Given that it is > > > also frequent, let's make the intent more obvious with some syntaxic > > > sugar by effectively making dependencies optionally conditional. > > > This also makes the kconfig language more uniform. > > > > > > Signed-off-by: Nicolas Pitre > > > > Hi, > > > > If we must do something here, I prefer this one. > > > > Nicolas, would you do another example, specifically for > > CRAMFS_MTD in fs/cramfs/Kconfig, please? > > I don't see how that one can be helped. The MTD dependency is not > optional. Could it be done as config MTD depends on CRAMFS if CRAMFS_MTD ? Jason