Message-ID: <440A08AD.7050101@bigpond.net.au>
Date: Sun, 05 Mar 2006 08:37:49 +1100
From: Peter Williams <pwil3058@bigpond.net.au>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: Mike Galbraith <efault@gmx.de>
CC: lkml <linux-kernel@vger.kernel.org>, mingo@elte.hu, kernel@kolivas.org,
       nickpiggin@yahoo.com.au, "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [patch 2.6.16-rc5-mm2]  sched_cleanup-V17 - task throttling	patch
 1 of 2
References: <1140183903.14128.77.camel@homer>	 <1140812981.8713.35.camel@homer>  <20060224141505.41b1a627.akpm@osdl.org>	 <1140834190.7641.25.camel@homer> <1141382609.8768.57.camel@homer>	 <4408D823.50407@bigpond.net.au> <1141448075.7703.11.camel@homer>
In-Reply-To: <1141448075.7703.11.camel@homer>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1268
Lines: 38

Mike Galbraith wrote:
> On Sat, 2006-03-04 at 10:58 +1100, Peter Williams wrote:
> 
> 
>>If you're going to manage the time slice in nanoseconds why not do it 
>>properly?  I presume you've held back a bit in case you break something?
>>
> 
> 
> Do you mean the < NS_TICK thing?  The spare change doesn't go away.

Not exactly.  I mean "Why calculate time slice in jiffies and convert to 
nanoseconds?  Why not just do the calculation in nanoseconds?"

> 
> 
>>If it helps, the smpnice balancing code's use of static_prio_timeslice()
>>doesn't really care what units it's return value is in as long as 
>>DEF_TIMESLICE is in the same units and contains the size of a time slice 
>>allocated to a nice==0 non RT task.
> 
> 
> Ok, thanks.  I wanted to make very certain I couldn't screw it up.
> Still, it's simpler to just leave it in ticks.
> 
> 	-Mike

Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
  -- Ambrose Bierce
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/