Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1938905ybz; Thu, 23 Apr 2020 08:41:40 -0700 (PDT) X-Google-Smtp-Source: APiQypIGZNivXJO9wU5k5U2xbM37QZeePbd6OR8zzYZ1/Pnw0j/7tP2ZPSzBwwWC0rE66sfNNIpJ X-Received: by 2002:a17:906:f1c3:: with SMTP id gx3mr3207319ejb.25.1587656500800; Thu, 23 Apr 2020 08:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587656500; cv=none; d=google.com; s=arc-20160816; b=ZBUnuQhvI8FLFtG05gtHysH3WalkIlhyMuwk70PwDE3t2NMlHxVBxarL4qh0oDWyu9 GGjnNC7t2sC2w8GVbz5WPk6PY0UyQZ3o5IhdXbXy5VVsYQioLXu+C5+kYuqiG5z15cxl o6O1nhJBqcI9cCebfif0i+QhvOSfKb/XSY0P9jtDCKsVZnohBiBMI6j/+Eqvi75HThp9 CwlVLQ+5eac8y49YtAAG/cpywYMecr2HyfrVxUR3Y1cC1Zg2rU5H3rwEWeF6ZwZts70G D7j5okCvZ9DN0y7UlLfq3EPy1fiREw2fSmXZ0imn0WFCBUsBS6SlXVPAF7jk+jivfKwF R0eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7p1NPBehoTzIXs1d2X2/gTGWiFS42FhzsmFyoLuRXRI=; b=xpSLPJDdyHDHWE93w+Pwre7XbLIAm7PAPCyEKXAvKQ3IXfK7S2mCSATCOVx9I6AU6t q16vdjnTjh8PqSlQvKp62ffaBACXQp16G+Pv89WyIifQceKmQTrIFLCgJMyeyy6phSaf yrLKYcWRKXmdOK+Y8vLIChcKq9VLm+N2htto09aOJHQTnjTVv8odHyiHrTliYed1iBv+ aLrlHZiL2uluAlpPzc/A5tZ6q4g+BEdR8MVFh+CKj/XTTFNNo7/pQs6gaeyaUmVdcguI pUYzWIybG7Do/AipOEfVHYUm5YPzS9FoM0jEk2r7WrfQg+MyxnyomPOwbZwh1dONe2MQ pGHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=GWvb0Ms4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y26si1465887edm.274.2020.04.23.08.41.15; Thu, 23 Apr 2020 08:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=GWvb0Ms4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbgDWPjV (ORCPT + 99 others); Thu, 23 Apr 2020 11:39:21 -0400 Received: from mout.gmx.net ([212.227.15.15]:37171 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgDWPjU (ORCPT ); Thu, 23 Apr 2020 11:39:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587656348; bh=tVK9wHiOkp+HiJDasb5SXHVH2+WN8NOIYB+YERfKM2Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=GWvb0Ms4UUk6kdlp/H1p0bUqoyWCpOnrpdbfcbSi9FW0otuyiMcsHuuRd/1JSnI/i 6mGbvzSx6G0pEccZSZ1gJ8RNPdSrbqP4nGK9Vehr9ddvcx/HmOT4EcJlLuPf3pLDOd HdfkymzpEUveOZaRIMmAH1L3fQpBTcIhKIGzRc2k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([83.52.229.196]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M8ykW-1jXfY53sUI-006Aja; Thu, 23 Apr 2020 17:39:08 +0200 From: Oscar Carter To: Forest Bond , Greg Kroah-Hartman Cc: Oscar Carter , Quentin Deslandes , Malcolm Priestley , Amir Mahdi Ghorbanian , Stefano Brivio , "John B. Wyatt IV" , Colin Ian King , Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Date: Thu, 23 Apr 2020 17:38:34 +0200 Message-Id: <20200423153836.5582-1-oscar.carter@gmx.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ez+aTspjR2dwAdEjcGrDYLjesRrwRUyke9QkGrpBfCvigvJ043Z qS0MkZ/xtlErRc4ca1V8ECZk9HZrm8qDs4EzJvkk5jC+N9Mgd7l3SFyRR2jNE19yl+HEe4L KROKFC14FAW5tefsb2dIdQ8ujwPjmmtZGMxL8F309qwl3Jte8rM5VMvYfSDy9ICQifGdZ0b Ho4fZmLSm76L34RFkhuAQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Lu4RGMyXhlA=:dTwuxiosGMrAjqHWh5IGMk BFVKJDbE8Ks+3EiWIJZT8O9+DxVpMEqGfH33ti4lzgGi4q2+I664jobM1JW+W69uEsjhV6hv3 8Q6vVbFPwbVu1o/IbUb/t2wdf3NbZUcSIrNeReN5tyahlMJi44ivp22uAXEDF4DDtTTgGaf/e +lSnYZtymMLzIPAVa2j8i+9YCImdZojmjA+aOjQ+xyL+GWujFRSncVK+bl84TcFrXNmifmRNK +1UfQ8mB/tQbLpPw2Fn/mCdpwzD9t+5k+PYuffuTlOvP7gJ1+PFbziI5b6FZ5e9b/t23rcHdt NsJmAY30YT6OiMlivAyBGjF5k1uDUmwn6EoC5xfyfRjCyhjGblBGhAFb2LIRHP47gt6XF7Duv HGZjJpIQnYZy60cR5suDWd1jxEWHkGrvGl29gJ1lzExokaAQpGdaY7YllYOXb2KKDtqwYn2lj 3ZIKvXygN56md2ltKUDemalaRukKG8caA4qtim4D408mjzXAUtWjS6h0b5NFTv4ztaVKtw16Z MoytBmNQJZfLJ9fV+tIr5g9k8/hf0ADUz5GT4hYXuxmOLq/GAWqZB4D8yCY0oRZLzorPRTeR8 vLsgzbP+24jgLIkQ2qhiRTbfKDAIDIDY3r9z3RyWE6kLcKC+ZDMiGJT8WnQdfBy4TtT8SdQIj BDIviYEQhxGVajgpaLShLniUDPWR+jUyOn47Dv8KBVUEsf5zscWVrL9LWGfSfnSNmtmyDkl9G QBoewJ//+TEGNXB3cxdxZRld2jsCb/VPhUtSFE1+xKcUF+5GZTzRgvv2cCWkLHxurA9LHf5ND lxICoUxIyJdXu6RlA3ZC4XVttm+ICWm7irLdGu28k7f3oT5Fo9mzRX7xEOTmL56LD0aiw47wL p19WwaWUATHaPvkfdbuV66by/xcYLjCdorK1iss4zCCcsmm5qrSO9WvUz8mwrZ7ysfq2UMji3 hoGrEQfa2aR2S6i84GF1zDSNPrBYlbSo5t5P1UsD2hSlc8YdJ/GLDPE09NMx0vNK7ordRLlvH 8BHNwJKibEVWfHIffCZst0GAClZGB56BK64q/avDX+KsbNDWTEAKbEvX7smcMvkpanlQP+vjM ENCq6OSvh4X6cQRItG60gX2oiUV/TZ6Zkoj/KuVrB2lQZCI3/XZhmSO+mWqYPbjKCquphLic4 eFenVdJHK7ep295Ns+EVe9FxBOvcXGrZ19M+hAe/iLTRkFXzTha9EvnlNzLZU8fms/snA8mhy 01mo2rkBxULu9AVmF Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series checks the return value of vnt_control_out_* function calls. The first patch checks the return value and when necessary modify the function prototype to be able to return the new checked error code. The second patch removes the documentation of functions that their prototype has changed as the function names are clear enought. Also, the actual documentation is not correct in all cases. Changelog v1 -> v2 - Remove the function's documentation instead of fix them as suggested Malcolm Priestley. Changelog v2 -> v3 - Rebase against the staging-next branch of Greg's staging tree. Oscar Carter (2): staging: vt6656: Check the return value of vnt_control_out_* calls staging: vt6656: Remove functions' documentation drivers/staging/vt6656/baseband.c | 35 +++--- drivers/staging/vt6656/baseband.h | 4 +- drivers/staging/vt6656/card.c | 176 +++++++++++------------------- drivers/staging/vt6656/card.h | 18 +-- drivers/staging/vt6656/mac.c | 128 +++++++--------------- drivers/staging/vt6656/mac.h | 26 ++--- drivers/staging/vt6656/power.c | 22 ++-- drivers/staging/vt6656/power.h | 2 +- 8 files changed, 156 insertions(+), 255 deletions(-) =2D- 2.20.1