Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200422220430.254014-1-irogers@google.com> <20200422220430.254014-12-irogers@google.com>
 <20200423112847.GF1136647@krava> <CAP-5=fVwfu0s8Sqhs7+aTqN1Gh2SaEu=feOEQssSu9MB+7hk8Q@mail.gmail.com>
 <0edf66da-bedf-c5e9-aa2b-e9073a2d0203@huawei.com>
In-Reply-To: <0edf66da-bedf-c5e9-aa2b-e9073a2d0203@huawei.com>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 23 Apr 2020 09:21:23 -0700
Message-ID: <CAP-5=fWTgdQ-RC-CtyEPKFvOPfbANajgT61+4k6-7S9poaNEog@mail.gmail.com>
Subject: Re: [PATCH v2 11/11] perf test: add expr test for pmu metrics
To:     John Garry <john.garry@huawei.com>
Cc:     Jiri Olsa <jolsa@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Haiyan Song <haiyanx.song@intel.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Song Liu <songliubraving@fb.com>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
        Leo Yan <leo.yan@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Paul Clarke <pc@us.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 23, 2020 at 8:11 AM John Garry <john.garry@huawei.com> wrote:
>
> On 23/04/2020 15:22, Ian Rogers wrote:
> > On Thu, Apr 23, 2020 at 4:29 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >>
> >> On Wed, Apr 22, 2020 at 03:04:30PM -0700, Ian Rogers wrote:
> >>
> >> SNIP
> >>
> >>> +
> >>> +static int pmu_tests(void)
> >>> +{
> >>> +     struct pmu_events_map *map;
> >>> +     struct pmu_event *pe;
> >>> +     int i, j, k;
> >>> +     const char **ids;
> >>> +     int idnum;
> >>> +     int ret = 0;
> >>> +     struct expr_parse_ctx ctx;
> >>> +     double result;
> >>> +
> >>> +     i = 0;
> >>> +     for (;;) {
> >>> +             map = &pmu_events_map[i++];
> >>> +             if (!map->table) {
> >>> +                     map = NULL;
> >>> +                     break;
> >>> +             }
> >>> +             j = 0;
> >>> +             for (;;) {
> >>> +                     pe = &map->table[j++];
> >>> +                     if (!pe->name && !pe->metric_group && !pe->metric_name)
> >>> +                             break;
> >>> +                     if (!pe->metric_expr)
> >>> +                             continue;
> >>
> >> so we go throught all the metrics for the current cpu
> >> and test the parsing on them.. great!
> >
> > It's not just the current CPU (such as skylake) it is every map
> > (skylake, cascade lake, etc), but this only works for the architecture
> > that jevents built.
> > If jevents built all architectures then this could check them as well.
> > Perhaps there should be a jevents test suite, but I think even then
> > this test has value.
>
> note: there is test__pmu_events(), which verifies that some test events
> generated in pmu-events.c are as expected, and also verifies that we
> create PMU events aliases as expected (for those test events). Nothing
> is done for metrics, ATM.

Thanks John, that sounds like the right place to start.

Ian

> Thanks,
> John