Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2036664ybz; Thu, 23 Apr 2020 10:25:14 -0700 (PDT) X-Google-Smtp-Source: APiQypLDeUTjhoZr9icFM24WJfpYlmzugpC/54qaCrwm68J7GYlh4kUD+ABQOT97HKAjacSOaN8G X-Received: by 2002:a17:906:af99:: with SMTP id mj25mr3497220ejb.151.1587662714812; Thu, 23 Apr 2020 10:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587662714; cv=none; d=google.com; s=arc-20160816; b=jdJQAmTOp3I8Hy+EcNrvhNq4L2O4GgCOKrT3eAk819NiY9g18QxgSYOeKW246emRS7 QFB+yJt3OXKuYrjJatL/XZlWF5iMfJnGuLTpmKqoFNr6v/mKXTC3+gEgQSfH8RjhUeFH pxLD9YZxmQm9arq9pu3X933o9vR5ZSefbAkd69gnboPzHts10ail8NjT61YeqlHC6ii4 9Ab6c5DyR02+RKpG7CMjGE4ync6f3nUlbFy9pJ4uILerqNIZcVUtODiVPQoKUuqTYotD Ip8mKxwPiXCjNDCDVfTPT6NHSGIOj4aTf9TOYpgknR9HQeUpchJms6tdUwJqFB4b21MR fUDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=0wANgCj5vRUmo46v3iXsaF+0jDF5DQ3Fmrf02hSbXgU=; b=RYL0U5GQZgITTGBu0oAv23f1ZSxz8GTEuNoFOZcob86E5D+hTZmUEnG0dIQ7cvebqk 0HjJvWSUxnTN03ABVixsPpUugEr2GvlQFsrlFT0mTVcJWsFb7cyqh+NBDUQAFx4jIDbK mVDHMPeJqKQ2lZ+geAh1pEYbUqRfutJlkOAjGqQqn10Fx3JH/yRO3UrtERZKDIBzJpbC IP2UQvx3OnAW4s6Iqh9VqJxkAUzArsEXiMjqs7GhcrYpWK0sm6O8Pfwz0CJkv0U0OheZ 5HzXxAMvnOONpfk3dXQbCL2bGdlhMFH3cdpukW7PF4XJk3qgaBtXp0SPVi6m0PWZOhY3 CIDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=D54CSUnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si1492954ejr.462.2020.04.23.10.24.43; Thu, 23 Apr 2020 10:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=D54CSUnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729895AbgDWRWS (ORCPT + 99 others); Thu, 23 Apr 2020 13:22:18 -0400 Received: from mout.web.de ([212.227.15.3]:45207 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729783AbgDWRWS (ORCPT ); Thu, 23 Apr 2020 13:22:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587662523; bh=0wANgCj5vRUmo46v3iXsaF+0jDF5DQ3Fmrf02hSbXgU=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=D54CSUnmwW9cH0++14F8sZwVFZDDfn/Ucl0lulSQDI0BwbbMRLxBrMRZF5FqbdygA w7JK6IQxnB2otGP2gmCYk8hIS13nbuHZUUJReqfbw+VFWDpojxgy4DiUK/FcXcETfF BHNzm2xfP6YdwsLRXKNNuYpox8XimvDsc471I99c= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.49.69.235]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LgYi5-1ioo502nrh-00nvnS; Thu, 23 Apr 2020 19:22:03 +0200 Subject: Re: console: Complete exception handling in newport_probe() To: Dejin Zheng , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Coccinelle Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Bartlomiej Zolnierkiewicz , Florian Tobias Schandinat , Greg Kroah-Hartman , =?UTF-8?Q?Ralf_B=c3=a4chle?= , =?UTF-8?Q?Thomas_Bogend=c3=b6rfer?= , Thomas Gleixner References: <20200423142909.GB1562@nuc8i5> <20200423170245.GA3417@nuc8i5> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <68178ac9-ae0c-2f97-2620-38393741b3a1@web.de> Date: Thu, 23 Apr 2020 19:22:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200423170245.GA3417@nuc8i5> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:CuxDU18RlEXaVaH5TBmSF1Yz8GXdhpiC0Hdth0O6u3YTlh7AQBo QV55xahdWrbJB9UdfppJEzwqrf6Dn5BTJA+PNOKQrA9tt+QZwJPnLK7b04hkpRKADqroE6O IrkDfIeN3ONXuGeuh3a0pS+joEorhdEp88SVdLwAwasyBY2b7JMf45xgyXwQyI0aprK6SfZ xWrPZknZkORF0uMTOrtVQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:aHpQ50XbsfM=:riywysSOpVopgGZohGamKR UydlNym/a89oBJDUp1USoPZuBRtdQ4psIgDkEKYi7eRBdtjlZqrQhLVjmQsFy/8ODzIYox6Mw f8agIq99CqRJiUMp5F8HXLy89fzXWq3FNvn14kfwqtA4TsnKpaB0IHA6NUXtgqvwsh5laN/9K 9/IliCTps6gJVZ3Z6MbYSBYlESJ0hznApgDfpGg2dyPmZM5YhC73iV/qAg4ePjVaJCINfh4BI Qgvm/yQWBqXefIxyaQM7mrHdJDozHvvio4yy2GxJaUbOhhsbMxVijeS/nebVyqrH32k1z+/sl FtuF6Pf6i5YnE00yefvNTkA2VQPgOx9FgW5/nYuocA7lnO0uB4vqgvnp+njxk4SkaVGPMCaCI /+6YgYG42OtUkLevceXARCfN9aS365H2wSFsXpMwINlGAimLTbKk0Ev5+Yqj6CF/e1OQIKXWX j/u1ep54NN8iL6tJldrgGWMFPO3K/wTKR8IcKevhcJMFhrk5ewTjGC75G137oh1pHIU+LqNY8 +HkvpZNzP+2DGedEOhksKQzk6do2CYIbP1AsJp9PbP7lM5ttCNz5xmJxOmgBdftL7IqTEyV4K vDTl4iPyNjsw3/GI8PR25p9ZSqIVwHGo7uyDq8H8sSAeZDicpCnOQkv84GFh+K5E1Txb6yYJy KDEDNQJKA8l8+lqmC/uFFmalczhCfNWfdEqc+O9vVznJPtu6hybVdA6NPIB8L+Hw/2q0lQ99f t4qPjkcciA+h9Fsmhrz1LEE2z9wyYapsq7dp8fl0FDvWoOyZt01QXltX8mIXLI9hmFbP4cvit ZPTLFUhawDexH6E8/eAJNe/u+DiN+oG/3tJrSj4huUbVojM0bURNxo0S1lwZPZMjUtsIUmCUX vN88lcY1Kro4aXsyT6nVXrdbw3oDWkwJzc3qhiRCW9V1eHEM1jFcP7g5OgCM48SNJQJ3sGnRc S233LgcbYagoao8z0xXTJjcN1+uGnjedgkBxsFDcFCohyLz5K5AEJLOdkK3B4BA1zWNx3Mh7n h1It4wRo7Qd/nRW9ckpNSi1YfosVJxfmhbDb3/T4bA5hLyW3jzSWfZxhxUbUXarpn5hd93RK7 7BkTS4qrbz3Og+zRBNE3OeycWGuoLojMilZ4LlCufsriIWG5xHnsZYWPL9NhsihYdVDNIVJDH 5eciLIxN6WEKgZpFVLzxtiUfp89d/CnAbNKg7PsGKuCTCSGRl/OpoVh6BJ9McgJQkPIKwSyWW 1VOXwH+qJ4spT6PD8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/l= og/scripts/coccinelle/free/iounmap.cocci =E2=80=A6 > Sorry, I do not know how to use the SmPL script. I proposed to take another look at the header of such a file. I imagine that provided information can trigger further development ideas for the continuation of a constructive patch review. >> Would you like to let any more source code analysis tools help you >> to find remaining update candidates? >> > yes, but I think the source code analysis tools only can found the simpl= e > repetitive issue. I suggest to reconsider this view. > and need spend some time learning to use it. This approach can be usual. > at different stages, it should have different methods for me. I hope so. > now, I think the best for me may be that read and check the source code. This can be also usual for a while. I am curious how much special tools can make your software developments more convenient and safe over time. Regards, Markus