Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1584689540-5227-1-git-send-email-weiyi.lu@mediatek.com> <1584689540-5227-3-git-send-email-weiyi.lu@mediatek.com>
In-Reply-To: <1584689540-5227-3-git-send-email-weiyi.lu@mediatek.com>
From:   Enric Balletbo Serra <eballetbo@gmail.com>
Date:   Thu, 23 Apr 2020 20:20:12 +0200
Message-ID: <CAFqH_523KpaCwhhHDKVCKaJgJUPc+7r03f6U=1XiNNQ1PaNN5w@mail.gmail.com>
Subject: Re: [PATCH v13 02/11] dt-bindings: soc: Add MT8183 power dt-bindings
To:     Weiyi Lu <weiyi.lu@mediatek.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Rob Herring <robh@kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        James Liao <jamesjj.liao@mediatek.com>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Fan Chen <fan.chen@mediatek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Weiyi Lu,

Thank you for the patch. Just a trivial comment below.

Missatge de Weiyi Lu <weiyi.lu@mediatek.com> del dia dv., 20 de mar=C3=A7
2020 a les 8:33:
>
> Add power dt-bindings of MT8183 and introduces "BASIC" and
> "SUBSYS" clock types in binding document.
> The "BASIC" type is compatible to the original power control with
> clock name [a-z]+[0-9]*, e.g. mm, vpu1.
> The "SUBSYS" type is used for bus protection control with clock
> name [a-z]+-[0-9]+, e.g. isp-0, cam-1.
>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> ---
>  .../devicetree/bindings/soc/mediatek/scpsys.txt    | 20 ++++++++++++++--=
-
>  include/dt-bindings/power/mt8183-power.h           | 26 ++++++++++++++++=
++++++
>  2 files changed, 43 insertions(+), 3 deletions(-)
>  create mode 100644 include/dt-bindings/power/mt8183-power.h
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/=
Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> index 2bc3677..1baaa6f 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt
> @@ -15,6 +15,7 @@ power/power-domain.yaml. It provides the power domains =
defined in
>  - include/dt-bindings/power/mt2701-power.h
>  - include/dt-bindings/power/mt2712-power.h
>  - include/dt-bindings/power/mt7622-power.h
> +- include/dt-bindings/power/mt8183-power.h
>
>  Required properties:
>  - compatible: Should be one of:
> @@ -27,12 +28,16 @@ Required properties:
>         - "mediatek,mt7623a-scpsys": For MT7623A SoC
>         - "mediatek,mt7629-scpsys", "mediatek,mt7622-scpsys": For MT7629 =
SoC
>         - "mediatek,mt8173-scpsys"
> +       - "mediatek,mt8183-scpsys"
>  - #power-domain-cells: Must be 1
>  - reg: Address range of the SCPSYS unit
>  - infracfg: must contain a phandle to the infracfg controller
> -- clock, clock-names: clocks according to the common clock binding.
> -                      These are clocks which hardware needs to be
> -                      enabled before enabling certain power domains.
> +- clock, clock-names: Clocks according to the common clock binding.
> +                      Some SoCs have to groups of clocks.
> +                      BASIC clocks need to be enabled before enabling th=
e
> +                      corresponding power domain.
> +                      SUBSYS clocks need to be enabled before releasing =
the
> +                      bus protection.
>         Required clocks for MT2701 or MT7623: "mm", "mfg", "ethif"
>         Required clocks for MT2712: "mm", "mfg", "venc", "jpgdec", "audio=
", "vdec"
>         Required clocks for MT6765: MUX: "mm", "mfg"
> @@ -43,6 +48,15 @@ Required properties:
>         Required clocks for MT7622 or MT7629: "hif_sel"
>         Required clocks for MT7623A: "ethif"
>         Required clocks for MT8173: "mm", "mfg", "venc", "venc_lt"
> +       Required clocks for MT8183: BASIC: "audio", "mfg", "mm", "cam", "=
isp",
> +                                          "vpu", "vpu1", "vpu2", "vpu3"
> +                                   SUBSYS: "mm-0", "mm-1", "mm-2", "mm-3=
",
> +                                           "mm-4", "mm-5", "mm-6", "mm-7=
",
> +                                           "mm-8", "mm-9", "isp-0", "isp=
-1",
> +                                           "cam-0", "cam-1", "cam-2", "c=
am-3",
> +                                           "cam-4", "cam-5", "cam-6", "v=
pu-0",
> +                                           "vpu-1", "vpu-2", "vpu-3", "v=
pu-4",
> +                                           "vpu-5"
>
>  Optional properties:
>  - vdec-supply: Power supply for the vdec power domain
> diff --git a/include/dt-bindings/power/mt8183-power.h b/include/dt-bindin=
gs/power/mt8183-power.h
> new file mode 100644
> index 0000000..5c0c8c7
> --- /dev/null
> +++ b/include/dt-bindings/power/mt8183-power.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0

This line should end with a '*/'

> + *

And this line start with a '/'


> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Weiyi Lu <weiyi.lu@mediatek.com>
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_MT8183_POWER_H
> +#define _DT_BINDINGS_POWER_MT8183_POWER_H
> +
> +#define MT8183_POWER_DOMAIN_AUDIO      0
> +#define MT8183_POWER_DOMAIN_CONN       1
> +#define MT8183_POWER_DOMAIN_MFG_ASYNC  2
> +#define MT8183_POWER_DOMAIN_MFG                3
> +#define MT8183_POWER_DOMAIN_MFG_CORE0  4
> +#define MT8183_POWER_DOMAIN_MFG_CORE1  5
> +#define MT8183_POWER_DOMAIN_MFG_2D     6
> +#define MT8183_POWER_DOMAIN_DISP       7
> +#define MT8183_POWER_DOMAIN_CAM                8
> +#define MT8183_POWER_DOMAIN_ISP                9
> +#define MT8183_POWER_DOMAIN_VDEC       10
> +#define MT8183_POWER_DOMAIN_VENC       11
> +#define MT8183_POWER_DOMAIN_VPU_TOP    12
> +#define MT8183_POWER_DOMAIN_VPU_CORE0  13
> +#define MT8183_POWER_DOMAIN_VPU_CORE1  14
> +
> +#endif /* _DT_BINDINGS_POWER_MT8183_POWER_H */
> --
> 1.8.1.1.dirty
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek