Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200423142627.1820-1-zhengdejin5@gmail.com>
In-Reply-To: <20200423142627.1820-1-zhengdejin5@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 23 Apr 2020 17:52:09 +0300
Message-ID: <CAHp75Vf1_SMk=_WDUrB97BGR6K6EXOdtgQ92=hTyMdVUoyWQiw@mail.gmail.com>
Subject: Re: [PATCH v2] console: console: Complete exception handling in newport_probe()
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, FlorianSchandinat@gmx.de,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-fbdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 23, 2020 at 5:26 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
>
> A call of the function =C2=A1=C2=B0do_take_over_console=C2=A1=C2=B1 can f=
ail here.
> The corresponding system resources were not released then.
> Thus add a call of the function =C2=A1=C2=B0iounmap=C2=A1=C2=B1 together =
with the check
> of a failure predicate.

...

> CC: Andy Shevchenko <andy.shevchenko@gmail.com>

Use Cc: Better to read.

...

> v1 -> v2:
>         - modify the commit comments by Markus'suggestion.

What suggestion? You need to be clear in changelog what exactly has
been done without looking to any previous mail.

...

>         console_lock();
>         err =3D do_take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1=
, 1);
>         console_unlock();
> +
> +       if (err)
> +               iounmap((void *)npregs);
>         return err;
>  }

I have briefly looked at the code (it is actually quite old one!), and
I think this is half-baked solution, besides the fact of missed
__iomem annotation and useless explicit casting.
The proper one seems to switch to memremap() and do memunmap() here.

--=20
With Best Regards,
Andy Shevchenko