Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2143782ybz; Thu, 23 Apr 2020 12:21:50 -0700 (PDT) X-Google-Smtp-Source: APiQypLmouJbAlEdZ52Vu+fSJDvTeM2ScOclYvkwkL1sbBO9psE30MytIjyZOUpI2H3YrMGMzq4I X-Received: by 2002:a05:6402:698:: with SMTP id f24mr4013466edy.260.1587669710389; Thu, 23 Apr 2020 12:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587669710; cv=none; d=google.com; s=arc-20160816; b=LbWKWSRRuSVzZ/aGnj6p3HS9If0UgXCVqtCNESE4YM8tXRF1K+Sauz30k7yuh6MGsl EHyis72PPmbRpldB1bGZemPi1o8l4CU3nFaE4W4IZB68uPKfw1k1KjAZoS3YzfzKeOwB 1MhJhjis10QJ5MW0246eT3NC72N4Di8yDSUueFKxGI+oSTmEyJ9q0baRF6Tar1vtSEos rnb5kIN0BcKH+1zJm3SZizcZCRsspmn3g+Y0aFa/E3cYkde/31PdiolL9QmnEqAqDsiw 5irq8BnLl8ORjo0+YyXbw6dxj2IW7EtSR8/PAZJcq//so+ZnfRQvA0xzGScTtevi+VjQ 6zBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=lLmBZL0FMhG+mFKlP2Ht3IzgRfKlXEzRMeQdQ+FbklY=; b=iY6oGx9WMIr61vCTiqW/ef3S0ELa0e6gjaHprRaV4hfd8pAO12j2TDubcwWR7furbM gPmtfKUEeQrvAFZ59/B3Vo7QU1P60PwG7OM26whJ3JYXpl0xRSOBerFwgza6FyfciNqg /sw8s7XcHymqo88AEkXWf99WoeE5oVKj7nBor1VYlguntygPeUQbGrfPgZvYU8AvSZa4 BwXawIw2WOCdHbW07JgxC4AK2Wu+7JvR4ISEbpLxOAz5Oi9F4Kn6n2KgoY3B5ftf1Uyd O+Qs/Pg/P6DJWJee6LWkxuZ0lTigbdMz8NbgOh06KgPMZWPWSjGmmorZLskjR+bVoptm v3kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=BMVw9gHa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si1664924edu.7.2020.04.23.12.21.27; Thu, 23 Apr 2020 12:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=BMVw9gHa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728798AbgDWOsM (ORCPT + 99 others); Thu, 23 Apr 2020 10:48:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726450AbgDWOsM (ORCPT ); Thu, 23 Apr 2020 10:48:12 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C82D9C08E934; Thu, 23 Apr 2020 07:48:11 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id C317422F99; Thu, 23 Apr 2020 16:48:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1587653286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLmBZL0FMhG+mFKlP2Ht3IzgRfKlXEzRMeQdQ+FbklY=; b=BMVw9gHa6625K6Ui86hhu5yBTBrixqKjDF/MkErR/f+ykPUOWc+923D2EJAhzY3SZQSwJC NATLzsxcUFj3zAA7qPUQpKwhO1ckB3eV+z6Qb4HppFp3BaweHTtEjzqngjmdjUX3d8gijp aRNO5cl2Zi5o1SJcnUN5hzdrVxIkWio= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Apr 2020 16:48:05 +0200 From: Michael Walle To: Colin King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" , Guenter Roeck , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: phy: bcm54140: fix less than zero comparison on an unsigned In-Reply-To: <20200423141016.19666-1-colin.king@canonical.com> References: <20200423141016.19666-1-colin.king@canonical.com> Message-ID: X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: + X-Spam-Level: * X-Rspamd-Server: web X-Spam-Status: No, score=1.40 X-Spam-Score: 1.40 X-Rspamd-Queue-Id: C317422F99 X-Spamd-Result: default: False [1.40 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; NEURAL_HAM(-0.00)[-0.881]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[lunn.ch,gmail.com,armlinux.org.uk,davemloft.net,roeck-us.net,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-04-23 16:10, schrieb Colin King: > From: Colin Ian King > > Currently the unsigned variable tmp is being checked for an negative > error return from the call to bcm_phy_read_rdb and this can never > be true since tmp is unsigned. Fix this by making tmp a plain int. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support") > Signed-off-by: Colin Ian King FWIW since Andrew already reviewed it: Reviewed-by: Michael Walle -michael