Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rsI0zVj6PkOkATLFwBc196W/Mj98ccoaPbRdLMfh0LBkUo/oVVYeEJWYNggn0G4q9g3ysnLcu4
 mXrRpNZ1vv2YCjBpdLPNkovPAwH6uN73cdaTxhfvVncruWdnfJZo0WbIme7dL3NolM4GinBYcv
 bJWPHUMh8a89BJI7j2L9yUwy2N0yZ/ikklAp2yU8ENKtL6t6c+K+Xo4ug9TQvDvgNUb/Sfat6O
 bB1RJCdYycrquqlljExgJvurBlGsJHoUotUPfaW7cZcKjUE+hwkeJbwE12MBwbrrFcdKkka8UL
 6NM=
Date:   Thu, 23 Apr 2020 21:17:47 +0200
From:   "Allan W. Nielsen" <allan.nielsen@microchip.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
CC:     Po Liu <Po.Liu@nxp.com>, <davem@davemloft.net>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <claudiu.manoil@nxp.com>, <vladimir.oltean@nxp.com>,
        <alexandru.marginean@nxp.com>, <michael.chan@broadcom.com>,
        <vishal@chelsio.com>, <saeedm@mellanox.com>, <leon@kernel.org>,
        <jiri@mellanox.com>, <idosch@mellanox.com>,
        <alexandre.belloni@bootlin.com>, <UNGLinuxDriver@microchip.com>,
        <kuba@kernel.org>, <jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
        <simon.horman@netronome.com>, <pablo@netfilter.org>,
        <moshe@mellanox.com>, <m-karicheri2@ti.com>,
        <andre.guedes@linux.intel.com>, <stephen@networkplumber.org>
Subject: Re: [v3,net-next  1/4] net: qos: introduce a gate control flow action
Message-ID: <20200423191747.vzfmh3x3qerqbx7z@ws.localdomain>
References: <20200418011211.31725-5-Po.Liu@nxp.com>
 <20200422024852.23224-1-Po.Liu@nxp.com>
 <20200422024852.23224-2-Po.Liu@nxp.com>
 <878sim2jcs.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
In-Reply-To: <878sim2jcs.fsf@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 23.04.2020 10:38, Vinicius Costa Gomes wrote:
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>Po Liu <Po.Liu@nxp.com> writes:
>>> tc filter add dev eth0 parent ffff: protocol ip \
>>          flower src_ip 192.168.0.20 \
>>          action gate index 2 clockid CLOCK_TAI \
>>          sched-entry open 200000000 -1 8000000 \
>>          sched-entry close 100000000 -1 -1
>
>From the insight that Vladimir gave, it really makes it easier for me to
>understand if you added these filters and actions in two steps. The
>first, you would add the "time based" actions and the second you would
>plug the filters into the actions. And I think this would match real
>world usage better.
I agree.

/Allan