Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <6342c465-e34b-3e18-cc31-1d989926aebd@embeddedor.com>
In-Reply-To: <6342c465-e34b-3e18-cc31-1d989926aebd@embeddedor.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu, 23 Apr 2020 12:15:49 -0700
Message-ID: <CAHk-=wg+TdPXZ4bDgEwg9x+0m0cmNhwAB3XDQNjwwMjUTG3GJA@mail.gmail.com>
Subject: Re: remaining flexible-array conversions
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Kees Cook <keescook@chromium.org>,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 22, 2020 at 11:23 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Just wanted to ask you if you would agree on pulling the remaining
> flexible-array conversions all at once, after they bake for a couple
> of weeks in linux-next[1]
>
> This is not a disruptive change and there are no code generation
> differences.

The "no code generation differnces" is a good thing, but how was that
tested? I assume just one configuration or architecture?

Also, it bothers me a bit that some of the diff is unrelated
whitespace cleanup. I'd actually be happier with a pure scripted patch
(maybe coccinelle, maybe something else), than something that looks
like it's at least partly manual. In particular, if I can re-create
the diff with a script, I'd not have to worry about verifying it other
ways..

               Linus