Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2304110ybz; Thu, 23 Apr 2020 15:35:10 -0700 (PDT) X-Google-Smtp-Source: APiQypLVnIhoovs45/oLJOlvEUHx295N5JnPSg6B6B/N/oZLQvPvM4oxlA8ytAyAHsuEjXee3f7F X-Received: by 2002:aa7:dd84:: with SMTP id g4mr4913642edv.273.1587681310263; Thu, 23 Apr 2020 15:35:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587681310; cv=none; d=google.com; s=arc-20160816; b=xZ52YJ8fSrOOLpcih/Q3+sCt114fyZtmnmo9NUlPapGPvcNW4Qh48bTsfiw1aDbVyF 6d+L9UTQQiF6FWB6AfEjjaSC2mFemmHpjn7wTJ3Uc3vzXwzGfqWVBYyC9G+N9C7/IqDg JLOLZuBG2hGnYOtmspxs8Y3J+4fAqMqAMKsdI3fuTtwD6fIyxV3Mjr7VUd5zIyjPRs4I j0YiTvuYR9HHLIQwTuSAWTWQuEse1ZXAILx9Py8mk+RUxncKXkamdm2MJ6koNehGBR2R lIgq356I4pqHrckP/0yOewirAJ1Eh+rJ4YhTSbpDbzTEgajv6+kugpOWDmUTGdWP5N4i jR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=kVA1DqcYF7UgxGLKbFDBPvDqnqmS446yBv3UmFyIvnE=; b=dvmH/9jY5/yFQhDDLulPWZHuJs4o5G+U+msbLdBw6oJ+BUMZJ9zmqL3vFqVpHlXLBS qJHG3k46ttT1pfOm5TBmwsFIoqmIC84/+ucXjg0NpyO7KLfzXglJ9DSIQnek5Yme9xJ3 UyPVAATMxpueHs93Mk4RC5nT8rOLwWGdeeXmOlEMmU90F5hyc40YnhuHF9qlIX2a/qP3 xj56wdqOAYj5EaytnhRvyNqYjZvZh3Pmb39AaQLai7lw0xeOClO8mpnoj1udw/8/15xJ dvMQgoERTQjThemgtL/XRDzP7vfY/UzzC/QN0RSnw0xy6skSe5Rzli/Sqaor3Q+qufwy +wMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si1993190edp.481.2020.04.23.15.34.36; Thu, 23 Apr 2020 15:35:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbgDWWdJ (ORCPT + 99 others); Thu, 23 Apr 2020 18:33:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbgDWWdJ (ORCPT ); Thu, 23 Apr 2020 18:33:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C25AC09B042; Thu, 23 Apr 2020 15:33:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C8D71127D6DDB; Thu, 23 Apr 2020 15:33:06 -0700 (PDT) Date: Thu, 23 Apr 2020 15:33:03 -0700 (PDT) Message-Id: <20200423.153303.460318719995342920.davem@davemloft.net> To: tangbin@cmss.chinamobile.com Cc: kuba@kernel.org, khalasa@piap.pl, linus.walleij@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH v3] net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe() From: David Miller In-Reply-To: <20200423021631.20800-1-tangbin@cmss.chinamobile.com> References: <20200423021631.20800-1-tangbin@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Apr 2020 15:33:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin Date: Thu, 23 Apr 2020 10:16:31 +0800 > The function ixp4xx_eth_probe() does not perform sufficient error > checking after executing devm_ioremap_resource(), which can result > in crashes if a critical error path is encountered. > > Fixes: f458ac479777 ("ARM/net: ixp4xx: Pass ethernet physical base as resource") > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied, thank you.