Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2320925ybz;
        Thu, 23 Apr 2020 15:59:34 -0700 (PDT)
X-Google-Smtp-Source: APiQypIJXefehiN/SjZO9jQHRmoYxsv7KFPiFMhglM267FjMe+bF+FToXVPAA07XaCk823fkvYpa
X-Received: by 2002:a17:906:1490:: with SMTP id x16mr4339250ejc.323.1587682774549;
        Thu, 23 Apr 2020 15:59:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587682774; cv=none;
        d=google.com; s=arc-20160816;
        b=ysl6M+Vke2MF58v/2sJY5mKSX1WIh/SKpF+OR4ocA+FZty049ERdPMoehT1oDRHlCP
         3qYe/0i5B3Xieu0vANmT+1Gcjyv7rAYQPGzswD0iy6U+l61ZfjFYVSGEO5JS2iodgt9u
         xS2BfNPQO0A0pSK3bNUeBNoBbZjl2k50uwXfWtHrta4exELcDREbatt9yTPGpOYiRS39
         HysbJeomE9WCvxRmgxBmpE5NhWmftixQsdXgkW4SlgGfGVQUUev2sgtL29FkJxSrKSdM
         6dEV1z3yWdagj6BKGS9XiDtdvfwFoNvZrShykCOvoPkRF8T+QtL0GmDWZ6zdavHvjcYb
         tOhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=3HWpyHtyff666xGkfhENMyBGj0mtZ8sDpvyp/1CzARM=;
        b=ZJYk/XaaskEjdeGdHyC61Xjka4szsUIHvCcZ5KsgXiCxqxZ0RVGNNIrkY+FitC0npT
         2J8rK7ld9sggeQhx8p1gU4uZNK/3dYjFcZ6aBS+Sndq9uL6Nf+bb91vLqga1KddykKpT
         GwBs1/VBSQ0AIOrvhZMhF/GKj/FPE3JDtgPJeJpbzohdD1+chLgW9Pvfzw62fsk7kYt7
         bW1ukj0f0lLzugTDSUGVpvvdSU1WDmG6yIDTZgylNYmA1HUYNUrDIoBk0BUchUdvE0/q
         wDaH0XDN2pLJvyEevbCr0wI5WYuDJNKHCIe0NDH64CYL+TcJ5yuhtEAss0IkUQGF56Cp
         7DSg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l20si2001929ejr.179.2020.04.23.15.59.11;
        Thu, 23 Apr 2020 15:59:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728017AbgDWW5L (ORCPT <rfc822;luizmacielfranco@gmail.com>
        + 99 others); Thu, 23 Apr 2020 18:57:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38612 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727065AbgDWW5K (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Apr 2020 18:57:10 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB67C09B042;
        Thu, 23 Apr 2020 15:57:10 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id CE580127E2661;
        Thu, 23 Apr 2020 15:57:09 -0700 (PDT)
Date:   Thu, 23 Apr 2020 15:57:09 -0700 (PDT)
Message-Id: <20200423.155709.424252739885282745.davem@davemloft.net>
To:     colin.king@canonical.com
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
        linux@armlinux.org.uk, michael@walle.cc, linux@roeck-us.net,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: phy: bcm54140: fix less than zero
 comparison on an unsigned
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200423141016.19666-1-colin.king@canonical.com>
References: <20200423141016.19666-1-colin.king@canonical.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 Apr 2020 15:57:10 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Colin King <colin.king@canonical.com>
Date: Thu, 23 Apr 2020 15:10:16 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the unsigned variable tmp is being checked for an negative
> error return from the call to bcm_phy_read_rdb and this can never
> be true since tmp is unsigned.  Fix this by making tmp a plain int.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.