Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2332336ybz; Thu, 23 Apr 2020 16:11:27 -0700 (PDT) X-Google-Smtp-Source: APiQypLyQxdTLhZnKWkWoR7ti5DuscprVita0tytlD4zMZFMi02HQSl0fIxB1B4MB1fi9+E4ta2T X-Received: by 2002:aa7:d0d6:: with SMTP id u22mr5006968edo.262.1587683487083; Thu, 23 Apr 2020 16:11:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587683487; cv=none; d=google.com; s=arc-20160816; b=Ex+dqVGVRjQy++7rAw0dC5sSpgkXqgAfXSasUG1ZUNXir7LvpVxf5xGeYv7GHbbxBg ht6Nga266EFU3OL3Tdb8LBSDhzNihTyVxUL/9FZbdkVncYwq81HmkTwqAor2/khD/ao3 vgoWUg2JKG0zZWjHD2mrZTy1OynEJChpmZ57yicAYbk1btUEB0l4kW8nhrhqmYp2tHiN 1KCka1CysIrdC40DZl8SeULrc9/j24sF+d0WV96jtYnJKfK3DuyTmHltlbdlKUSKsK7j WLzRMlvG/ww1jk+JncDIEo2OhYnaFlZvM7w9doauMNXErW+yht96PEkd9sqNKjkq6/hA orcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition; bh=QbKXwKhwAXQrvCUvxve9fzy+QNemJ+Q4V+03oYCrAr8=; b=m2V2BsxEHcXFM4yNQrnwBnmSI72RoOiZT2h+Ud+deib0h+0+eBDfsgtV4fqxjG6OyH XE6H5vymeliZ9bmat4gtLvUcRrtNsZnLLX2lP1HO2Ej8VCRHoR1KXd+dBx+vjS0x0z/9 mt+BxVuUG4/PcdUs9z9mgtmnBFQWyrmCSb1uSzUuT1qzN2TOlnEUHsQV/QDNu3WjIxYj ZnIthdvb8z8TScumaRgYv1LgEaqF5YihsU5MVuZnmojcNrbaTPN5v4ucLN7o+Nx28p3a +daOGU6XRxNpzpCSckBa0ULPsXyKlEnbdT9KpSZALLdo8ZQOK6P9V0MmPNi4jCV48owh n9eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si2094831edn.502.2020.04.23.16.11.04; Thu, 23 Apr 2020 16:11:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbgDWXHM (ORCPT + 99 others); Thu, 23 Apr 2020 19:07:12 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:49696 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728422AbgDWXGr (ORCPT ); Thu, 23 Apr 2020 19:06:47 -0400 Received: from [192.168.4.242] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jRkvU-0004if-EO; Fri, 24 Apr 2020 00:06:36 +0100 Received: from ben by deadeye with local (Exim 4.93) (envelope-from ) id 1jRkvR-00E6po-Le; Fri, 24 Apr 2020 00:06:33 +0100 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, Denis Kirjanov , "David S. Miller" , "Jose Abreu" Date: Fri, 24 Apr 2020 00:06:01 +0100 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) X-Patchwork-Hint: ignore Subject: [PATCH 3.16 134/245] net: stmmac: 16KB buffer must be 16 byte aligned In-Reply-To: X-SA-Exim-Connect-IP: 192.168.4.242 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.83-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Jose Abreu commit 8605131747e7e1fd8f6c9f97a00287aae2b2c640 upstream. The 16KB RX Buffer must also be 16 byte aligned. Fix it. Fixes: 7ac6653a085b ("stmmac: Move the STMicroelectronics driver") Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings --- drivers/net/ethernet/stmicro/stmmac/common.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -270,9 +270,8 @@ struct dma_features { unsigned int enh_desc; }; -/* GMAC TX FIFO is 8K, Rx FIFO is 16K */ -#define BUF_SIZE_16KiB 16384 -/* RX Buffer size must be < 8191 and multiple of 4/8/16 bytes */ +/* RX Buffer size must be multiple of 4/8/16 bytes */ +#define BUF_SIZE_16KiB 16368 #define BUF_SIZE_8KiB 8188 #define BUF_SIZE_4KiB 4096 #define BUF_SIZE_2KiB 2048