Subject: Re: [patch] zaurus keyboard driver updates
From: Richard Purdie <rpurdie@rpsys.net>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>,
       linux-input@atrey.karlin.mff.cuni.cz,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20060305080924.GA7145@flint.arm.linux.org.uk>
References: <1141517165.10871.26.camel@localhost.localdomain>
	 <20060305080924.GA7145@flint.arm.linux.org.uk>
Content-Type: text/plain
Date: Sun, 05 Mar 2006 09:47:55 +0000
Message-Id: <1141552075.6521.3.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 718
Lines: 18

On Sun, 2006-03-05 at 08:09 +0000, Russell King wrote:
> On Sun, Mar 05, 2006 at 12:06:05AM +0000, Richard Purdie wrote:
> > + 	request_irq(SPITZ_IRQ_GPIO_AK_INT, spitzkbd_hinge_isr,
> > +		    SA_INTERRUPT, | SA_TRIGGER_RISING | SA_TRIGGER_FALLING,
> 
> This looks bogus (and unbuildable).

Thanks for spotting. The changes have been tested against older kernels
(2.6.15) and the corgi changes against current git but I messed up when
updating the spitz changes.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/