Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp112501ybz; Thu, 23 Apr 2020 19:40:38 -0700 (PDT) X-Google-Smtp-Source: APiQypLoRFWwLttTi/En5oIJ14BRPzKFZVGE7rfqOfQQZhTAFlFELgzOGwWbV+BjlMegdEm0V41x X-Received: by 2002:aa7:c312:: with SMTP id l18mr5617207edq.161.1587696038811; Thu, 23 Apr 2020 19:40:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587696038; cv=none; d=google.com; s=arc-20160816; b=v4atZ0Qc2Vpx3HyBtvpevD0YYY262yMYPVolbcf8PLYXVU0eF7YgWZ6y7638ke0XAu rDiXUpHzq6LScrkrAtjXx2vf2189bv4Es3jttiJv9N5LtCJGnaGqGpX1hWJYNvJGgBGn KvEkO6PPib3FG+M89RqcMiUTGAXFdX478D5vhhXOsVK3UAgiudTcgrXpE4O26Pypo+ji fWxsYx4H3fm8ut8z4TUO/1F0gHEMDQ5JrH1JOS+Vq96kS7kAvi0+FV7fl6t8oQtyL0yh M2dVm+ZE39o29m8LhKVDeQLgobE2KL0j7kZI+8ppChySeRzejP5JdK5ptjFESzBPMYsz sTzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=xkSGRkF++k+CMpZ51T6z7LFsFmj1btnV8v6kQtU62/U=; b=Cd2V76BGaSa9tniRQuTElY2bs+TdGn4Of6raNQ10Lz4pfCIv6SRQyzPhRG/ENoi9A4 vcMzo7o9IV1ClIW7OB/0NQEvsgbFHTAWPlkyqikK918LNbzrfrjs8jyBQ2EV/jgxw7j4 rPn8SZkxGUjBaCLyyPEnVbIdT6c6KunZgcdNkdMcnHLFw8sWtH5GY+MiRCyEFbF1WMJq GllgqourwtA2J2d5D2X8zfzPP2ytIFPpxgWVclXkmm2X/uP02tTwU7BrF2BTs1vjxfHb N8LEKUhUGuwSEbZsLhw1mQki0hqV/bjU8vi7n/7FG7qUoOBBEakED0kqt8USEgtviCrC rSfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I+gDnRKq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si2188563edm.43.2020.04.23.19.40.14; Thu, 23 Apr 2020 19:40:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=I+gDnRKq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgDXCi0 (ORCPT + 99 others); Thu, 23 Apr 2020 22:38:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbgDXCi0 (ORCPT ); Thu, 23 Apr 2020 22:38:26 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67222C09B044 for ; Thu, 23 Apr 2020 19:38:26 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id d184so4075415pfd.4 for ; Thu, 23 Apr 2020 19:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=xkSGRkF++k+CMpZ51T6z7LFsFmj1btnV8v6kQtU62/U=; b=I+gDnRKqpg1I86DxyMy4+YzJ5N2lmDVvQJ7IZOBFnPURDa2WG8Jb6UGne5D1//TcpC O4zuO/zL+S686HpKagdoYlACOgwWl7ZSSm8OI4Yb9OYvGHc2Q7KiwndV185AATwlDngc JUe42JJmqlYbxWYQ/Li/bfgJ+dBqY5J233/Tc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=xkSGRkF++k+CMpZ51T6z7LFsFmj1btnV8v6kQtU62/U=; b=AaeWGDfmtOXaq2BsjUTD59VyD1T2U90qSkEI1xv+SL4hMFjsidu85lpD4tCyzSWuc4 iXPWQIN9mO85zLOGVg+fC7VOh1i4GtbyLs/I1QxX1ssbqVccYqrs2qLM0u9ZOqSBB/fy 7Uc6vkFVbGAxQguV/7Z3IVvxUpl0Q7qzuQgrfRNZHnxb3QKtC9pBZ0Tx4tbWf5xv+FWW uohEAjZNOClloObkAI6TqjLzlvbgiZs6vWeGhp7AANz4whI3hCA6oDEkRrP4niDDKaex nFbQpxH55LM0xJIfgekXq2FmlmtgknKUozKP6pMeZ9WxshVMfU9OUd22TsjX0+Q8kVzX cLSw== X-Gm-Message-State: AGi0Pub6nOFg99Yb+WZLD9BfUCqHWty7N8gf4d5n9BmykYlyL4DfBzTf 0qJWqOzDFtGbmScqt2mMpnvhtdK0hJs= X-Received: by 2002:a62:38cc:: with SMTP id f195mr7024640pfa.85.1587695905622; Thu, 23 Apr 2020 19:38:25 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id c28sm4014957pfp.200.2020.04.23.19.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 19:38:25 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid> References: <20200422145408.v4.1.Ic7096b3b9b7828cdd41cd5469a6dee5eb6abf549@changeid> <20200422145408.v4.2.I1927d1bca2569a27b2d04986baf285027f0818a2@changeid> Subject: Re: [PATCH v4 2/5] soc: qcom: rpmh-rsc: We aren't notified of our own failure w/ NOTIFY_BAD From: Stephen Boyd Cc: mka@chromium.org, mkshah@codeaurora.org, evgreen@chromium.org, Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org To: Andy Gross , Bjorn Andersson , Douglas Anderson , Greg Kroah-Hartman , rafael.j.wysocki@intel.com Date: Thu, 23 Apr 2020 19:38:24 -0700 Message-ID: <158769590404.135303.4049749400685142607@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Douglas Anderson (2020-04-22 14:55:00) > When a PM Notifier returns NOTIFY_BAD it doesn't get called with > CPU_PM_ENTER_FAILED. It only get called for CPU_PM_ENTER_FAILED if > someone else (further down the notifier chain) returns NOTIFY_BAD. >=20 > Handle this case by taking our CPU out of the list of ones that have > entered PM. Without this it's possible we could detect that the last > CPU went down (and we would flush) even if some CPU was alive. That's > not good since our flushing routines currently assume they're running > on the last CPU for mutual exclusion. >=20 > Fixes: 985427f997b6 ("soc: qcom: rpmh: Invoke rpmh_flush() for dirty cach= es") > Signed-off-by: Douglas Anderson > --- Reported-by: Stephen Boyd Reviewed-by: Stephen Boyd