Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751298AbWCEO40 (ORCPT ); Sun, 5 Mar 2006 09:56:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751327AbWCEO40 (ORCPT ); Sun, 5 Mar 2006 09:56:26 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:11488 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S1751298AbWCEO4Z (ORCPT ); Sun, 5 Mar 2006 09:56:25 -0500 Date: Sun, 5 Mar 2006 15:28:59 +0100 From: Pavel Machek To: Andrew Morton , rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Russell King Subject: [patch] fix hardcoded values in collie frontlight Message-ID: <20060305142859.GA21173@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 59 In frontlight support, we should really use values from flash-ROM instead of hardcoding our own. Signed-off-by: Pavel Machek diff --git a/drivers/video/backlight/locomolcd.c b/drivers/video/backlight/locomolcd.c index ada6e75..2bcff84 100644 --- a/drivers/video/backlight/locomolcd.c +++ b/drivers/video/backlight/locomolcd.c @@ -20,6 +20,7 @@ #include #include +#include #ifdef CONFIG_SA1100_COLLIE #include @@ -27,7 +28,7 @@ #include #endif -extern void (*sa1100fb_lcd_power)(int on); +#include "../../../arch/arm/mach-sa1100/generic.h" static struct locomo_dev *locomolcd_dev; @@ -82,7 +83,7 @@ static void locomolcd_off(int comadj) void locomolcd_power(int on) { - int comadj = 118; + int comadj = sharpsl_param.comadj; unsigned long flags; local_irq_save(flags); @@ -93,11 +94,13 @@ void locomolcd_power(int on) } /* read comadj */ + if (comadj == -1) { #ifdef CONFIG_MACH_POODLE - comadj = 118; + comadj = 118; #else - comadj = 128; + comadj = 128; #endif + } if (on) locomolcd_on(comadj); -- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/