Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200423203416.133274-1-swboyd@chromium.org>
In-Reply-To: <20200423203416.133274-1-swboyd@chromium.org>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Fri, 24 Apr 2020 09:10:28 +0200
Message-ID: <CAMpxmJUEnpQjPFJUdSKhOwikPqo6NPqFzJf_eT4ju7212x8O9g@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: devprop: Warn if gpio-line-names is too long
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Alexandru M Stan <amstan@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

czw., 23 kwi 2020 o 22:34 Stephen Boyd <swboyd@chromium.org> napisa=C5=82(a=
):
>
> Some DT authors (including myself) have messed up the length of
> gpio-line-names and made it longer than it should be. Add a warning here
> so that developers can figure out that they've messed up their DT and
> should fix it.
>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  drivers/gpio/gpiolib-devprop.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devpro=
p.c
> index 53781b253986..26741032fa9e 100644
> --- a/drivers/gpio/gpiolib-devprop.c
> +++ b/drivers/gpio/gpiolib-devprop.c
> @@ -37,8 +37,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip=
,
>         if (count < 0)
>                 return;
>
> -       if (count > gdev->ngpio)
> +       if (count > gdev->ngpio) {
> +               dev_warn(&gdev->dev, "gpio-line-names is length %d but sh=
ould be at most length %d",
> +                        count, gdev->ngpio);
>                 count =3D gdev->ngpio;
> +       }
>
>         names =3D kcalloc(count, sizeof(*names), GFP_KERNEL);
>         if (!names)
> --
> Sent by a computer, using git, on the internet
>

Patch applied, thanks!

Bart