Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm: amdgpu: Move static inline keyword to the front of
 declarations
To:     ChenTao <chentao107@huawei.com>, David1.Zhou@amd.com,
        airlied@linux.ie, daniel@ffwll.ch
Cc:     Hawking.Zhang@amd.com, evan.quan@amd.com,
        andrey.grodzovsky@amd.com, Monk.Liu@amd.com, kent.russell@amd.com,
        linux-kernel@vger.kernel.org
References: <20200424031316.61662-1-chentao107@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <7d50f774-ebd0-e700-9713-209ccb8010f0@amd.com>
Date:   Fri, 24 Apr 2020 09:40:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
In-Reply-To: <20200424031316.61662-1-chentao107@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0PR01CA0092.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Fri, 24 Apr 2020 07:40:54 +0000
X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 79f95a3d-1a54-4d3e-9f84-08d7e822d2e2
X-MS-TrafficTypeDiagnostic: DM6PR12MB4404:|DM6PR12MB4404:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB440437F7BBB0A02EB712BA9883D00@DM6PR12MB4404.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:105;
X-Forefront-PRVS: 03838E948C
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4401.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(39860400002)(376002)(396003)(346002)(5660300002)(66476007)(66556008)(66946007)(6666004)(31686004)(66574012)(316002)(81156014)(8936002)(31696002)(86362001)(186003)(16526019)(4326008)(2616005)(8676002)(2906002)(6486002)(52116002)(478600001)(36756003);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Yv7ta53FIj3BiLu3k9Th0VJOXX1Jd6us6P7arlzDgD8Skgab93MuQnTUBw18SN6xq1MM30zFDRoinJbyfGi8y/9HKlyEhQObYMG+3Az2ubSEIrXLdAecL8HA0slS1zQpp//nwtF34yWum7Wk482DDsnn9h1pr7rSd2BouGwhT8YriJk/FbM2auxKAurk8EVlReYqsYfENNkGZ7wS5tv0/RC9rHZaurNfCUv4qqB9Qs8LOX1X1dAGqfEC+djZw7cQn5ltLfictBJSX2crJVTQlYxEZjzad8UQLtBqNbnCKSbySSVLhCp+pCRv95Yn2LAg/ZzfMQZK6P9wtW1r1/yjP4ArEqbuK1HJHCh154Xw99Yvx3CW00+xnYRlAPIpnescT5OcPtPhLI5xx2auarVQomI4It1Nwr4cdA6jtJzjvXLqLwErEuhH9n7GRCVcT2qT
X-MS-Exchange-AntiSpam-MessageData: ZQm2YdqrTVTNTQL/IV0EXArANAozfp/cz2zZY/S91rqLR5OKnO7rQ7jwQdggrNXxlQMT6OcfLFZwe3KqpBqV+ZDgH8Zh7fV0nYm9ZbeF5VRYdtJarNJH9iEAFhtIlIaU0EXfMCIEWL6F4YLW9dmu4yKfOPKsFL2yB6DVz4yATUp2Ns/FQcG8Wg9J8RjrdE3bAstuEVv1q8KaK9YI4XTlaQrYceyvqKdXg0zXSXLB9k/3FRFzuQrcEeDeZ3vKKcc2BcuHwIEXT3eNEJgKD8ubwRhsFNU4CFhpuFv4fyNJ0KesxH/8FVm+j9C+NH28Tjq5cKcfOMNrFwQaElAFDSG3wL4dBQjK6z0tgGU3TCUus9qTdbz1S/iwcomE/V00boUsKbULel3Y+t8p6nE9d7MNugUxBu+B+qxMekIxABqIdaH8V8F0v7sznOcvyxntAprbnT1yowS0g6q3ig8taeoxvn7kyBsUGoEem0N9BSVEs+rQ30NKb3gqqHTDQ2vpl+n2CUZrs+o83lAudQ1dz5lWWqXtqyGxPzH5HmGAshsY1zL21iA+VniXcLo3HwJE9G0RRtHiIia76tWyWdtdHDF+MKwfoggj+ZoZwvGgCz7+eGasp4nyY/jQaLiGngH7K35WaCHk5WfUuYJiGay/vt1XTpA10/4IGweXSblg92VM7mshj63mDA+CASsC94Dq7/MtBa7d1BgUWig/340z4PiW9waDcNiF2yX1NBiq2YN79zS7E4+6zl52MVtvcqhpOVAbOboJYj5HuDq/VDRg7m1MpkdIKqy9vn5hpyv5RpPxT8H3zCwWVTKUFqpMLmv85gzHmKjeqZ3a6ouslHUXTbMrRIuaV03KhLOxKF5iuZGO36Q=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79f95a3d-1a54-4d3e-9f84-08d7e822d2e2
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2020 07:40:56.3163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2mwLs6Lc8Xk1aQlM0fDTnl3z+Jnn1BV/YfSsd0p6MlRdT56Pu7a/bxnQyl/W1bju
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4404
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 24.04.20 um 05:13 schrieb ChenTao:
> Fix the following warning:
>
> Move the static inline keyword to the front of declarations
> amdgpu_device_wreg_no_kiq, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘static’ is not at beginning of declaration
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘inline’ is not at beginning of declaration
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ad1c66763dc1..d53a5e3f464b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
>   		BUG();
>   }
>   
> -void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> +static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
>   					     uint32_t v, uint32_t acc_flags)
>   {
>   	trace_amdgpu_device_wreg(adev->pdev->device, reg, v);