Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp355578ybz; Fri, 24 Apr 2020 01:27:04 -0700 (PDT) X-Google-Smtp-Source: APiQypLguHpqWlW9qW+wal/LHcY8Fp11EQocLpC+qBuwSK8al7vudjyIJgzCvSlVJzXO5jvuQUHa X-Received: by 2002:a17:906:d20e:: with SMTP id w14mr5924707ejz.19.1587716824320; Fri, 24 Apr 2020 01:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587716824; cv=none; d=google.com; s=arc-20160816; b=0ezkzBvW+mQEnwd9MjKOGzjy8RL7X5RHeqwvW3RzD1qaDguGNwBtwp6svlY7dtihwT hD0vEWlfEdb47aijrwp8D+O8tJRv2ZBJkuSPpgQyz7UzZD9l2SLfS1nSjToiTtfGD/Cq 81XCwe/lbHAdRTut0lDNzpfvLgmNovkT1v84UXYIZoJuyO8plvC37+EiS8etSgM19HX8 JW5zBUKyUYIY5hj2n8WBhExoSy3B+ef9LSu2ny3RheGVzy20L3mOky/HVd7mzrbs7S4H WTfM6uTsFWZdopO+qIFLlfPXwFCUFkfZ5Y+pV+joZ2NdxXeSjrhklsgj6VT+4AEtBZB8 5Ofg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=wFtxELK4DRPdhpCSSl//9WFLFuKDKAqSFmtiDIx/HXk=; b=txaUuO4xfvC+Fk+Xtgx65pFxqiz0kCmOAbZo/AePS2aWfwmmIw4AycWSW+0XuQXA8K a1PKExYlpaf9zwldSP+wmRrZ+nfx7mk4q4lZSfY4uwKDB4KHPIhusGHb2ZOAoBzTodXq qrEp7TKw16LG17KvepP6GW8E/uTxDkxXqvR0DUbMLAzjF2la/ok0MgINtZfcGyruViUJ htO397FjTq19ww9BR87Z9zbT3ZuUrXo4RlkgO8ctAcRJ945pMzbQUwxexrcxkUd6dSNi XPxjdDocFjP2uzfe2qlxr/e6fimhRBjsy1bL33OFV0im8NRpTaSZ3gk2+O9a0yVqhPxo efQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f6si2466759edw.325.2020.04.24.01.26.41; Fri, 24 Apr 2020 01:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgDXIYl (ORCPT + 99 others); Fri, 24 Apr 2020 04:24:41 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:56783 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726028AbgDXIYl (ORCPT ); Fri, 24 Apr 2020 04:24:41 -0400 Received: from [192.168.0.4] (ip5f5af075.dynamic.kabel-deutschland.de [95.90.240.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id C355F2002EE1A; Fri, 24 Apr 2020 10:24:37 +0200 (CEST) Subject: Re: some questions about uploading a Linux kernel driver FusionRAID To: Xiaosong Ma , song@kernel.org, linux-raid@vger.kernel.org Cc: ty-jiang18@mails.tsinghua.edu.cn, Guangyan Zhang , wei-jy19@mails.tsinghua.edu.cn, LKML References: <6a7c0aba219642de8b3f1cc680d53d85@AM0P193MB0754.EURP193.PROD.OUTLOOK.COM> From: Paul Menzel Message-ID: Date: Fri, 24 Apr 2020 10:24:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Xiaosong, dear Tsinghua, Am 22.04.20 um 14:26 schrieb Xiaosong Ma: > This is Xiaosong Ma from Qatar Computing Research Institute. I am > writing to follow up with the questions posed by a co-author from > Tsinghua U, regarding upstreaming our alternative md implementation > that is designed to significantly reduce SSD RAID latency (both median > and tail) for large SSD pools (such as 20-disk or more). Sorry for the late reply, and thank you for wanting to upstream the driver. > We read the Linux kernel upstreaming instructions, and believe that > our implementation has excellent separability from the current code > base (as a plug-and-play module with identical interfaces as md). Is there a chance to integrate it into the current driver, and then choose it, when creating the RAID? > Meanwhile, we wonder whether there are standard test cases or > preferred applications that we should test our system with, before > doing code cleaning up. Your guidance is much appreciated. […] > I am Tianyang JIANG, a PhD student from Tsinghua U. We finish a study > which focuses on achieving consistent low latency for SSD arrays, > especially timing tail latency in RAID level. We implement a Linux > kernel driver called FusionRAID and we are interested in uploading > codes to Linux upstream. > I notice that I should separate my changes and style-check my codes > before submitting. Are there any other issues I need to be aware of? > Thank you for your time. Is your code in some public git branch to be looked at already? Otherwise, I believe just posting the patch train with `git send-email` and a cover letter, might be the best first step, so the developers can comment early before you put too much time into refactoring. Some easy to reproduce test scripts to verify the performance benefits would indeed be nice, but I do not know, if that can be integrated into some Linux kernel test infrastructure already. Kind regards, Paul