Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp398922ybz; Fri, 24 Apr 2020 02:20:30 -0700 (PDT) X-Google-Smtp-Source: APiQypLAFyprpXiymRRPiC5qdbnA3B/HHHkbQb3nyQWBGIE+88eJ2ut/DPXGflO6Pe3/xe/Kh6BE X-Received: by 2002:a05:6402:1694:: with SMTP id a20mr6107480edv.322.1587720030114; Fri, 24 Apr 2020 02:20:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587720030; cv=none; d=google.com; s=arc-20160816; b=ttCUS2oHDmKlWIhzIAinnQrnw2i9QPJinUZxDNBu9Z9DgPgpLmzWRCoHOmyIAn/ILN oAkd9ajd+EdM8eqABR77O2Cy+lBpRyOznqPWf7CNNIEEimzuBrMhnHIH9ezyAIh1vmeA UGDcvXP5tmRmy1Dh0Nkcgye0SPC0hxWmatl5Oms3WMXchnyF9TGXD1apHxCnI0TnPBPM 3j8mJ/tSj/KEFlKC8WwXnJaadnqDo9uJ1zEkTwXgGWg5MvukwYkqQGY5ExfTc25Zig5I Kw5ZLwEWdDNelaWRbjgsgAM+zx3LJ+3ipPWThwLxXbev8b6h1W4LBtAr2PVkiNPIX7p9 XHEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GiWyPt7yzmACBp+FM5CBU27WrasEL3zEd6YMjPXRRYw=; b=DxkqYZMNw05Cxc5aO7yDwWZkV4/kZH+WtlBkv8uCWfbrrgdNB+KmTHANcOF7mM5hSP DPiz2bCErpQiaeN/KIknLsfdSo6ZkFe1bIQuAfxM3NKTm9CZQodiZAd+qvqgGSN3GNT9 esTpoSPQJI8K2VmXwEaIq5/m5+vEPH3uoqKgt07Fq/jbng3oXMns2XeihEvDBNccbkUx fC9M9AmsdzG5MSgT7brElbFzUOCvnfBWTAuGoB5aeFd8Z+YwrF7JB0EpX1gj4VTlOOrG U8CzpTXzA20as/O/q3/vkbmoDcbMN3ivTlrh11gJVfQWm07qh2bBoB6UoXlW2jhAQdoE uZOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hLqeK807; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e23si1499445edy.578.2020.04.24.02.20.07; Fri, 24 Apr 2020 02:20:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hLqeK807; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbgDXJPt (ORCPT + 99 others); Fri, 24 Apr 2020 05:15:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgDXJPt (ORCPT ); Fri, 24 Apr 2020 05:15:49 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC7AC09B045 for ; Fri, 24 Apr 2020 02:15:49 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id h12so2541307pjz.1 for ; Fri, 24 Apr 2020 02:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GiWyPt7yzmACBp+FM5CBU27WrasEL3zEd6YMjPXRRYw=; b=hLqeK807AIl6oploSr0Ba6ECKM0p7TJKe7Ek3q2RmBD0GalqEqtMmRgxnkTlqcmdzV ImxmiB17WCsKRZzUUwf15tdxBIvx8kVfKqvsamdbhlDfruuX1a/rIrojrXzb7AmzvZnw L/qkKYRqVsQM5Y6gA907HSjwfpLGR5zddHhtKDXluMyl6xz5DNoWeedHM8EwIj+zJRct YGRYb5B6VaHlc00x4WiOwUXXe0lfY6iZ6Zs2FtKP23Al/RAc2TlBD5WToZDRaVsNd0VF 8JosDlT9ZgqC9CyuqWcb0/7Dh8Wv8VY7VpWPMCNx0aa4cmIudmY0/WbW+98c0jYN39hH APeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GiWyPt7yzmACBp+FM5CBU27WrasEL3zEd6YMjPXRRYw=; b=EavR9/VQ8RY/TRvgIrHnRl2PurDJS3Po5bWS0HTuRcmEI1oN2row1q3jChBPJfNhTB 2HKW2KluAOqmjPAPw5ybS75SbYLS3xD0l0HcwVoqxTH72NdUXUZNIr6dDLL6oSNycYyk PJFn1MPXS3VBy6ztyZINSY0az6zTj19vHnA8l1nDaFxmFSfo8OgrDbaCl7sT5OrfCzSb YbfO0fypDAKTl877FEwK93a6wmZTErUHh4SlAjHYu/4zNLg7oLtVKiiH5D3QVWVGA3aB W8RRlcRbzi2YVGTBAdWtf3UP9392SiPOAMG92vE3MFLOf6kXrYkttPXB7V1xdpGdHJQN TnVQ== X-Gm-Message-State: AGi0PuZuNW+8AR145xHdvM2sIvunGxyrAsP6dvKF1Ao9U1HkzsW5UXaT MSxgo60+HfXvRy2G7Bv5QUk= X-Received: by 2002:a17:902:8218:: with SMTP id x24mr8335621pln.192.1587719748506; Fri, 24 Apr 2020 02:15:48 -0700 (PDT) Received: from Asurada (c-73-162-191-63.hsd1.ca.comcast.net. [73.162.191.63]) by smtp.gmail.com with ESMTPSA id u13sm4301584pjb.45.2020.04.24.02.15.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2020 02:15:48 -0700 (PDT) Date: Fri, 24 Apr 2020 02:15:33 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com, broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl_esai: Remove the tasklet Message-ID: <20200424091533.GA8856@Asurada> References: <1587711246-27226-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587711246-27226-1-git-send-email-shengjiu.wang@nxp.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 24, 2020 at 02:54:06PM +0800, Shengjiu Wang wrote: > Remove tasklet for it may cause the reset operation > can't be handled immediately, then there will be > endless xrun interrupt. The reset routine is really long and expensive, so not sure if it'd be good to do it completely inside HW ISR. Have you tried to clear xEIE bits to disable xrun interrupts, before scheduling the tasklet? If that does not solve the problem, we may go for this change.