Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <61c8c547b9148b8297aa946a93df23608f408d28.camel@sipsolutions.net>
Subject: Re: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for
 RCU list usage
From:   Johannes Berg <johannes@sipsolutions.net>
To:     madhuparnabhowmik10@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc:     linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, frextrite@gmail.com,
        joel@joelfernandes.org, paulmck@kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Date:   Fri, 24 Apr 2020 11:24:40 +0200
In-Reply-To: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102943_941405_F4B3E85F)
References: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com>
         (sfid-20200409_102943_941405_F4B3E85F)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-04-09 at 13:59 +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> 
> ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from
> ieee80211_send_assoc(). Add lockdep condition to avoid false positive
> warnings.

Again, wrong lock!

Over the course of the three patches, you've now claimed that any one of

 * RTNL,
 * local->iflist_mtx,
 * local->mtx, and
 * sdata->wdev.mtx

are sufficient to iterate the interface list, but only the first two are
really true.

johannes