Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp475153ybz; Fri, 24 Apr 2020 03:50:31 -0700 (PDT) X-Google-Smtp-Source: APiQypJhDp92k9QJPAUyFqwnezKO9zIg62UMsbPiLJI77kjfz9Mp9gGWqJVTaE7KmdV8wx6H/Quq X-Received: by 2002:a17:906:88c:: with SMTP id n12mr6839949eje.92.1587725430828; Fri, 24 Apr 2020 03:50:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587725430; cv=none; d=google.com; s=arc-20160816; b=TdkWBolRAkqiymPk1tLFA6S1/lbwsZw9X2BTfY4q3AfHXUETrQ6Gy5NH3wm7s21pIk uTcBsJTigrn8vrsXiC51WGh5uqja9cdWxtxr562d+2zsb5ClcLsBjzHjDTXHcxqXeLkk 5RDqZmD+GUBBSt8lfzHxXoeUPegpL1WCIOKUJuBlwn3VR0vDplc1YE+nK/GO83fSUi8D B0OR0zJtp4+O4aSwjBZICiZDaC8dcbZVI7gFAKH6I1w6/TIreZO4vkUsYLtF7TkJ7y4D sLPQBOQWzaYZtt4llNCqVKCd4b9jnkuRG4KnWq4z2j24lwBuz6NFRouOTXWLSsvjNPy1 ZIiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=IewgKVWJvxyhdE4TKcCYoEvv7xD+0FgI7QpltLoN86M=; b=CqXCCooXh1hfSPZUs10dwYhQOtVNIaFXZPg7GVQ/HFfci1jGQj6t0UG4aJHs31e0MY M2tn3jh8kfFF/ULOzUymeO6A5+RPc6aM6WPyS8CTrtGC+m4Mu/pXQojxzF+ho2lieFv3 RRu8N0AR7X90tMUdI3PTRL7jhHULDa410jweGC8PByvNZ2MOdiBfF5tGA6n3xcwhpCsl WWCRlgz3gAdrqJV8qG1zgXor9mWITcdw/drRP2upadOfL76hV/h34ELwoxjO68EEu6BC hecb6TbHRShx50tg+y6AQx8W8QsSJa6twqTkXEtQo6bdMWpPA6ZSLQz179+znT+CrSjt 6MwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GP0EHgRP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si2886233edn.251.2020.04.24.03.50.07; Fri, 24 Apr 2020 03:50:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GP0EHgRP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbgDXKqu (ORCPT + 99 others); Fri, 24 Apr 2020 06:46:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:50640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbgDXKqu (ORCPT ); Fri, 24 Apr 2020 06:46:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 146732064A; Fri, 24 Apr 2020 10:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587725209; bh=IewgKVWJvxyhdE4TKcCYoEvv7xD+0FgI7QpltLoN86M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GP0EHgRP62u/B+a36tX2U1F85Xn34FBjvigS/Dh48dUQcn+s+5WAOzeGnKIQb/g91 ZUpE4Znj6F+mCM+3S7ncf/anWckRzANZL1ebbEG8WmnbkOplFDkoNtXpONO8UnKm4m ORzXELHjJGWh9a9316DHpqzcxadJBitPQ8SJUh5o= Date: Fri, 24 Apr 2020 11:46:46 +0100 From: Mark Brown To: Charles Keepax Cc: Shengjiu Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, tglx@linutronix.de, allison@lohutok.net, info@metux.net, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm8962: Force suspend/resume during system suspend/resume Message-ID: <20200424104646.GC5850@sirena.org.uk> Mail-Followup-To: Charles Keepax , Shengjiu Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, tglx@linutronix.de, allison@lohutok.net, info@metux.net, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1587708727-13657-1-git-send-email-shengjiu.wang@nxp.com> <20200424104347.GJ44490@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m51xatjYGsM+13rf" Content-Disposition: inline In-Reply-To: <20200424104347.GJ44490@ediswmail.ad.cirrus.com> X-Cookie: Information is the inverse of entropy. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --m51xatjYGsM+13rf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 24, 2020 at 10:43:47AM +0000, Charles Keepax wrote: > intended to put the CODEC into runtime suspend. I am guessing the > reason you have problems is because of the driver doing its own > pm_runtime operations in set_fll, which probably takes an extra > reference preventing the power down. Is a more complex fix > correcting the interaction with DAPM the correct solution here? Or just updating the machine driver to turn off the FLL when shutting down (or even when the device is idle in general). --m51xatjYGsM+13rf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6iw5YACgkQJNaLcl1U h9DD5Qf/aNoM7gNzCjtutvsHglTVC2IeVikq5qWepEIkjE2Za8SbDHTb+o+EFvnR D21oMf1biEpUZitXu5tFrk+vhCLLXD+lsPathUE0suZubm1tUrmsEyLmZ5tzWO5R LE/KIAA0VGzkInIq8ywzUP15Yu8ruUMFfDWiKpFWn8t8yFfkOqWhH5VpvE59b0za dixQK3ngHIh2D37+GxZ0iJWDpaF0mmk1qfn8wAKYWp3RxMCTbNRcRfzZm+qXkGPd QUJnnN3+dovMnbR1U838fb9x83DjFndOOCGoRbNJ9NA6mPuB1Ubpu/e6QE8d0BOT 7G3qLT5B4KrGBSIaRbBzSj9flX7Snw== =SsMB -----END PGP SIGNATURE----- --m51xatjYGsM+13rf--