Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp508717ybz; Fri, 24 Apr 2020 04:28:09 -0700 (PDT) X-Google-Smtp-Source: APiQypJQlEMMXn/oSIdCZBto7lt3XtrJBmp5en812Ogg0v+weoY1xxATALAjXQUj+Dv+H7sLX/o3 X-Received: by 2002:a17:906:f295:: with SMTP id gu21mr6906862ejb.83.1587727689515; Fri, 24 Apr 2020 04:28:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587727689; cv=none; d=google.com; s=arc-20160816; b=zgbd7OtKJv5qX4TlsTjHYM76Oa3Vj2KY+OC6zCTdrFT1SHxFIKyulkZhCLai53EmAs fKdBpJULQh8m9SUqSjnXzkW8+uvoxZkhMXAxNTQ+34o2Gc0ACxKVJRTtksMSlf5Qa3q6 smnpky2ajTdJYqBE0rvMh1yIxEBTvk+vbS9e8c4XbETqIUCFiT53DcWfOjRkAuyIUA2p dU2kup/HL7J5OfX2n6ejYkXO/CpGyzSSzhSoplTz1KKDt8LtpZwijc8JGL9pAh3PXvcE EYSTYI3KHTbv4Blx2NgRjuKTR/tOuTBKLcq4f+V6FN+htF5WlJKupy2mKfVfw4knzc/+ 7gDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+1IyTN9FAdqr8UNcdVP7VZ1cqY50ZOUrm4GzYl/26To=; b=oTnU3vplq/JEpIeWWuZWYOyLklDz3BlgL5XaAWf3beg2pKVSsrHad1C7qGRw5cEaDz drYd3g/z3RlreAPR1hckvii037UDeVECul6Byi3eEhs9o6gaJ8b6gxlYlWtaa5w6Eo2J 7VKkj3ypAIFnACkRIZX/ymrCOrMkVtTplzX5CRB7hGpZM7wFiYu2EXHFVNekmInLMH/2 +EC3JGDBLyMwWAGVvk1b5NostJLn66hVSw+J6gEXG9SUE6sxt15Sr/c85zoZiSSBbvja eoL+ZW75fZK2dT0bWjhT0kf9ovK+GfWQQOOcNb3paw2CiKCiPLq//RUgNpPXjioBsiai rPnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t20si2977612edy.543.2020.04.24.04.27.45; Fri, 24 Apr 2020 04:28:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgDXLZ6 (ORCPT + 99 others); Fri, 24 Apr 2020 07:25:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:47772 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbgDXLZ6 (ORCPT ); Fri, 24 Apr 2020 07:25:58 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jRwSw-000650-Ud; Fri, 24 Apr 2020 11:25:55 +0000 From: Colin King To: Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: cx231xx: remove redundant assignment to variable err Date: Fri, 24 Apr 2020 12:25:54 +0100 Message-Id: <20200424112554.12456-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index b0cd51134654..c5e21785fafe 100644 --- a/drivers/media/usb/cx231xx/cx231xx-417.c +++ b/drivers/media/usb/cx231xx/cx231xx-417.c @@ -1734,7 +1734,7 @@ static void cx231xx_video_dev_init( int cx231xx_417_register(struct cx231xx *dev) { /* FIXME: Port1 hardcoded here */ - int err = -ENODEV; + int err; struct cx231xx_tsport *tsport = &dev->ts1; struct vb2_queue *q; -- 2.25.1