Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp513946ybz; Fri, 24 Apr 2020 04:33:43 -0700 (PDT) X-Google-Smtp-Source: APiQypJ+fIEw2D10USt+5W7YKWDtweLQJUcEu42zHtg8ma3MZPp1JUyssXPVZu0jKvEWVQx6DyiF X-Received: by 2002:a17:906:7743:: with SMTP id o3mr6892094ejn.120.1587728023064; Fri, 24 Apr 2020 04:33:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587728023; cv=none; d=google.com; s=arc-20160816; b=j1x8Rwq6xfQMKfI/RuM1VuHQ1PGpFLTIosSLgg7JHPK1Z4Vpwx4+F0pFNSqzNzvhb6 4tKQ9KE0G1VpcwQvUdnEXV9Dm+ulUqUru6JNwkjYQAqImyzxHnRNF9+OFIOmcTCag4FI 2kKFXf5ODt5zftBzVmOFPvkMuL/GvUAi4ZrxokuARpei6AMDo+9TczKRtNf/cBmD/XHX SAwpt70VEDOgzw/lPO7gkjvHkYzgLiNY1Vwjhp4gan6l3z4+DOm9fA5/ijNyBufG2Vq1 DqqM/4vjlm9N5I9ZSvE8RwkJ2Wd/wGl7K+UuGPLo21lJM52TvwE7oL2s3vyiYrymxr+1 ugGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr :dkim-signature; bh=ot5Q0giBxowWEbwxAzzYyCSY+h/D/bG3UXD5qUGdW9A=; b=hJdCiYvaSDgDhhMuEmAqqbx3C56eRQ6x9CisFBKW7vgOR48uh8pgEG2l0AA1mnOlon 52KiFiEBsWQj6vGmAsLS5MoyiWsUqhyJdLhfhhuDSV5kupl5RWg1g/f3GTzPqtncoilm pGwK8Md1nWnb4WPFJHzeH0fYj6BJL8ABFsMxm18ctr3ip2E2jjDW1gjVMtVEesvTcN7K kl9dpO4as0rxye886ELv2FCTlVvLqJ29ipd5krstn6wmKkvZnfXczapang+R/y6fo9d6 5s2nVXkQXR1wKGc7M189bHSQwxsPifDhyQ8AnbVx9c5l3khjruiY8351kwFW/L/XLLTU +aOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=WVSzKh0f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v29si2828458eda.533.2020.04.24.04.33.18; Fri, 24 Apr 2020 04:33:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=WVSzKh0f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726959AbgDXLbQ (ORCPT + 99 others); Fri, 24 Apr 2020 07:31:16 -0400 Received: from smtp2.axis.com ([195.60.68.18]:3713 "EHLO smtp2.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbgDXLbP (ORCPT ); Fri, 24 Apr 2020 07:31:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; l=430; q=dns/txt; s=axis-central1; t=1587727875; x=1619263875; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ot5Q0giBxowWEbwxAzzYyCSY+h/D/bG3UXD5qUGdW9A=; b=WVSzKh0fYVbXdf2T+iYitTwWTA03HUdSe4MxnpLMDc38vrIfG9rYalhy R55VTrl+kdqaZIYGfCTq5t/y4wm6hWXHVgyAIbSO2hs3u4KIgTXgVq1eD kFVPm1gyDCBMEMHFElIGFgZaUDcP1Q0OXi0DlpefUPCrWNm4TCjKm85gF ThMAbUb/8OnSYlFrG2HZMr+awmYbUxIkGvU3rheknnwRTkXa+seTAsFCu Oy1U9VWdrIFnbj2CGk+wpORdiC8+TCKews573yNK/CkvHEuu+sGGxLkID zZCBYYurVofyzZmdi3BFt0rf2xI+476dgG5Bl5G+kPOYbKPLubBFJlgAw g==; IronPort-SDR: ICzpKZuNol7nYjx5G80qZMBsZB2OnaOjir4QeT4xleVclot0wuGEADpo/FAA0ppw+mViyRLL+6 lsUjdFQWJnfGeiXVZnWNpseiH4D0XGH0enPU0Fbj//Y3HB68duvhZZ+p11uGBSbDPs9x/W2O8P wYniP86nWVgdST9Xq40hm/DTSVhzLTQ6/6xiFfFJMMUEGWnfDmPO7Ds6wAfbaMU8OmaBrmTwZU NYtcCw77yd/4UgEpENDriWtOyno9/OiSO8waD19QWcYkMSjy7jm1XddvmO9IXBYwJFOVZYtNSB jLI= X-IronPort-AV: E=Sophos;i="5.73,311,1583190000"; d="scan'208";a="7791947" Subject: Re: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data To: Wolfram Sang CC: , , , References: <20200424090443.26316-1-bjorn.ardo@axis.com> <20200424111337.GC1959@kunai> <5038e4c1-440b-0a56-978b-a8c9fac061cc@axis.com> <20200424112705.GD1959@kunai> From: Bjorn Ardo Message-ID: <8d1cd553-4607-4092-7020-911e43e02d11@axis.com> Date: Fri, 24 Apr 2020 13:31:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200424112705.GD1959@kunai> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.0.5.60] X-ClientProxiedBy: XBOX03.axis.com (10.0.5.17) To XBOX02.axis.com (10.0.5.16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You got a new patch (ignor the first one, I forgot to update the version number). On 4/24/20 1:27 PM, Wolfram Sang wrote: >> As I can see in drivers/base/firmware_loader/main.c in function >> _request_firmware, then the fw will be released internally if it returns an >> error value. > Ouch, of course! > >>> Also, do we need 'error' and 'ret'? Can't we reuse one of them? >> Yes, I can fix that. > Great, thanks! >