Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     "Winkler, Tomas" <tomas.winkler@intel.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     Joao Pinto <Joao.Pinto@synopsys.com>,
        Joao Lima <Joao.Lima@synopsys.com>,
        "Alim Akhtar" <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type
Thread-Topic: [PATCH 4/5] scsi: ufs: tc-dwc-pci: Allow for MSI interrupt type
Thread-Index: AQHWGizLweIWC0leREOPucyddXRWn6iIKkeAgAAAomA=
Date:   Fri, 24 Apr 2020 12:02:12 +0000
Message-ID: <BN8PR12MB326683F270F887D309490462D3D00@BN8PR12MB3266.namprd12.prod.outlook.com>
References: <cover.1587727756.git.Jose.Abreu@synopsys.com>
 <9b5c2d47997629c55ac14ce594771e9e8f254c74.1587727756.git.Jose.Abreu@synopsys.com>
 <a8a9d40b0bef460c8e593e0add88094d@intel.com>
In-Reply-To: <a8a9d40b0bef460c8e593e0add88094d@intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 71bdfd06-91e9-4556-d003-08d7e84752c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 12:02:12.3797
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 12HSJ212Ds2gAtjlcSxFfd5Lkrb7ylp9CwQ8nvVTJ74XWBC/mEslC92wUD6vZ7G75ewiDqjpS9OMNr/9rd0qhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3620
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Winkler, Tomas <tomas.winkler@intel.com>
Date: Apr/24/2020, 12:55:57 (UTC+00:00)

> >=20
> > Newer Test Chips boards have MSI support. It does no harm to try to req=
uest it
> > as the function will fallback to legacy interrupts if MSI is not suppor=
ted.
> >=20
> > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
> >=20
> > ---
> > Cc: Joao Lima <Joao.Lima@synopsys.com>
> > Cc: Jose Abreu <Jose.Abreu@synopsys.com>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: Avri Altman <avri.altman@wdc.com>
> > Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> > Cc: linux-scsi@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  drivers/scsi/ufs/tc-dwc-pci.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/scsi/ufs/tc-dwc-pci.c b/drivers/scsi/ufs/tc-dwc-pc=
i.c index
> > 74a2d80d32bd..e0a880cbbe68 100644
> > --- a/drivers/scsi/ufs/tc-dwc-pci.c
> > +++ b/drivers/scsi/ufs/tc-dwc-pci.c
> > @@ -136,9 +136,15 @@ tc_dwc_pci_probe(struct pci_dev *pdev, const struc=
t
> > pci_device_id *id)
> >  		return -ENOENT;
> >  	}
> >=20
> > +	err =3D pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> PCI_IRQ_LEGACY | PCI_IRQ_MSI , is enough  you don't have MSIX

Makes sense :)

> > +	if (err < 0) {
> > +		dev_err(&pdev->dev, "Allocation failed\n");
> > +		return err;
> > +	}
> > +
> Where do you call pci_free_irq_vectors() ?=20

Right ... Will be fixed in v2. Thanks!

---
Thanks,
Jose Miguel Abreu