Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp547868ybz; Fri, 24 Apr 2020 05:12:58 -0700 (PDT) X-Google-Smtp-Source: APiQypLC8Uo1T21snLLKSoDJPmVhFA3MMZmT0/kJOURWh5XtawZXcgvAFZEoErnE/6PzmARiB7k2 X-Received: by 2002:a17:907:20a2:: with SMTP id pw2mr7051702ejb.252.1587730378406; Fri, 24 Apr 2020 05:12:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587730378; cv=none; d=google.com; s=arc-20160816; b=dqQORbuq0qTSz0Les9vfeeMCmkgYkFI35dPUj8hdacKEIxryhXLg6EbjDYeltbkwY/ iz17d7kW/ObYHtvuAhkK3WdBdaUlZvKIXQ/VIGTaX1IDgER+pe0ixfyLXa2kpxEGc9F0 NBLUNkcuG1TT9xNEpJqaFFrzJ84DvFD3U7KV4QyxdEuJDAnR3tcWgaLwvZK7EBhUntmK EmACOyvbJU9V6id4PmhXXhQVfxFFg81BdQvqmgb/yBf3UcED6o+R+b0RrN3FM8Toszwk 8cbMpNcj0Li1JhGgHWGuH7/Dzq1f0Kt/d1oSdvLD+pe/IL+K8YSF0VC1SY9JlhCBnIXT qZqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Bd80W57PTH9iM106Pfh19U14qLu4Af3XnHF2u4ktSpQ=; b=Bc0alL+F5dUaWm2R22beIWZFjIUNsOOZ/c9j3VyLq2xU/Rjyb947O6xxwLE58BndQn dD6xbYHpqT+SZ+rbk/1pqlguK1DUvH1oIz3qOr2p39BWSl6q5HdoEuBF/Rc23F5kG2ot QLjPZ5wvvxTY4BKrVW6sHayuc45qpqfZ51iF5osFcdMhuisJVf/H/sDAUOC5eYX5zZG8 CZaXlrzBv4G4h8Z+7wOX3Mw8AfQu+pQtnuuBQogG1IzwfJtl/2+5+rLIAPyIdtflVEHg TIAccUDtWO1vlwrRXxcYKi0eLmjnXZ3KSujPNSbuGn75zVqdOINC8AqD6jVlTXh/l2E/ NSeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o28si2987873edz.180.2020.04.24.05.12.32; Fri, 24 Apr 2020 05:12:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726872AbgDXMK4 (ORCPT + 99 others); Fri, 24 Apr 2020 08:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgDXMK4 (ORCPT ); Fri, 24 Apr 2020 08:10:56 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E46FFC09B045 for ; Fri, 24 Apr 2020 05:10:55 -0700 (PDT) Received: from ramsan ([IPv6:2a02:1810:ac12:ed60:8134:2f28:3a79:6257]) by laurent.telenet-ops.be with bizsmtp id WcAs2200D3LKRvX01cAsFr; Fri, 24 Apr 2020 14:10:52 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1jRxAS-0005xQ-CC; Fri, 24 Apr 2020 14:10:52 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1jRxAS-0001KK-9Z; Fri, 24 Apr 2020 14:10:52 +0200 From: Geert Uytterhoeven To: Pravin B Shelar , "David S . Miller" , Jakub Kicinski , Tonghao Zhang Cc: netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] net: openvswitch: use do_div() for 64-by-32 divisions: Date: Fri, 24 Apr 2020 14:10:51 +0200 Message-Id: <20200424121051.5056-1-geert@linux-m68k.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 32-bit architectures (e.g. m68k): ERROR: modpost: "__udivdi3" [net/openvswitch/openvswitch.ko] undefined! ERROR: modpost: "__divdi3" [net/openvswitch/openvswitch.ko] undefined! Fixes: e57358873bb5d6ca ("net: openvswitch: use u64 for meter bucket") Reported-by: noreply@ellerman.id.au Signed-off-by: Geert Uytterhoeven --- net/openvswitch/meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c index 915f31123f235c03..3498a5ab092ab2b8 100644 --- a/net/openvswitch/meter.c +++ b/net/openvswitch/meter.c @@ -393,7 +393,7 @@ static struct dp_meter *dp_meter_create(struct nlattr **a) * Start with a full bucket. */ band->bucket = (band->burst_size + band->rate) * 1000ULL; - band_max_delta_t = band->bucket / band->rate; + band_max_delta_t = do_div(band->bucket, band->rate); if (band_max_delta_t > meter->max_delta_t) meter->max_delta_t = band_max_delta_t; band++; -- 2.17.1