Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp564753ybz; Fri, 24 Apr 2020 05:31:55 -0700 (PDT) X-Google-Smtp-Source: APiQypLMarg444zGZIEseDnoeNocqajhq0GRfh82GZNd2i9RInRmVkLD6+I0VQO3/sbpwx/1xXpv X-Received: by 2002:a17:907:2170:: with SMTP id rl16mr7128011ejb.238.1587731515355; Fri, 24 Apr 2020 05:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587731515; cv=none; d=google.com; s=arc-20160816; b=QdkJt0M4C7sknyBN8uDMr3JqkFcXf3OC4Whvj10L9SM35+TrO5jj95/OmVs839obGr BpZz4NlfO/COIvrP6dUeinZUmDVvIZWFKnFNJG0qpeGywv1UZ0MnJAhwN4ZmQquRtJQC Jc6zgjpuG6kVwE/PYmcIxzZT13uv7RC7etXFcfjMF6f9rZq3jvHZhKtSOP1FIabyvOcp ZtLP9UITm3yMlX6NITeutb0SoT9sz3IEevEuzbiRg1vCr7+AlBOQsmHWc+gLIqIyHyn+ GR3rWvwpc3OzLhjHjSoPBZwcvSTvMCt10PULUM27rY2ctxgwQf55kmJDrUL0XzyACqVB yapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=3Wnn5PIF6XuCizSG0kL8Z3HAMWti202DTX9aM/EuL8Y=; b=q7O2y65iw9V1Q2Lv2uDbAmktbPloVBjGmS6hkCsCFM9+38fhhVImYLn9AfHCdarSu3 fN9+9gI4IUUzB7urxjVA74uTAyLsh+rCyxfhnVvLECB70iFOM9mUesoEjKb4YbxQD4tn vrDZb9v9q3ko5Hj7/fn8r6Ua+k/Zgxce2OhASddrwV7GR8+mWlaMZ7C1jiwGf36GpRNX zY3UP2jW3xr5Vak2UKPNzxDtRYmSrsUfgAVV3fWumJ1tLR31DPX0tMFWFsBhkTopSYP4 w4kBdMK9t7XMLrU+Mzm5936fqM5oUWP3+CV8bdstKXuDZmClBNKpA0ISkN/GtkCAukEh UJcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r28si2709449edw.570.2020.04.24.05.31.31; Fri, 24 Apr 2020 05:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgDXM2i (ORCPT + 99 others); Fri, 24 Apr 2020 08:28:38 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2896 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728827AbgDXM2g (ORCPT ); Fri, 24 Apr 2020 08:28:36 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 25CA67D325C9B243DC51; Fri, 24 Apr 2020 20:28:34 +0800 (CST) Received: from huawei.com (10.175.101.78) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Fri, 24 Apr 2020 20:28:24 +0800 From: Yang Yingliang To: , , , CC: , Subject: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison Date: Fri, 24 Apr 2020 20:52:26 +0800 Message-ID: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com> X-Mailer: git-send-email 1.8.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.101.78] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The type of loaddr is u8 which is always '<=' 0xff, so the loaddr <= 0xff is always true, we can remove this comparison. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/ptp/ptp_clockmatrix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index 032e112..56aee4f 100644 --- a/drivers/ptp/ptp_clockmatrix.c +++ b/drivers/ptp/ptp_clockmatrix.c @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm, /* Page size 128, last 4 bytes of page skipped */ if (((loaddr > 0x7b) && (loaddr <= 0x7f)) - || ((loaddr > 0xfb) && (loaddr <= 0xff))) + || loaddr > 0xfb) continue; err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val)); -- 1.8.3