Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp568572ybz; Fri, 24 Apr 2020 05:36:01 -0700 (PDT) X-Google-Smtp-Source: APiQypKLqEss1zYoLoWslKxnTdhCmovKuCxteRL4ipF2bw9vwnN4KWMBS/DnxegLrNbjHzskBLZ0 X-Received: by 2002:a50:8f45:: with SMTP id 63mr6757371edy.177.1587731760909; Fri, 24 Apr 2020 05:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587731760; cv=none; d=google.com; s=arc-20160816; b=j+jd5tSof8a7mChQaCxnzm3KDhaLfu2d9tjKqY7XmGdweG6QY4oJ/7GDGAieIhZzur F1iYMN7fIfWbsk6VVz9REHXidTOBgJMZZHcibNhKDF8RtdnkxHMwFj6pBgQl3rWI7eP9 7vV0D58CrilG+KpBgfYk8CcEAwRWVcPbF4pygFgalSrxMOHLiHYhbmdmSpu9QU/girWz A0/SXJHNp5+smQ2wSGZ8NGvfUN0/GijxktT5oct6ojbJrzFlZhqcf7hfXORg93BttID6 y/71qHCCXIIMy3PEExKrKNe8gXHncWVt54yXoPYgDQYAQSVED/tGC5wjYkv6ZbhFN3xH g/og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GXI9M5h+pAq6dnN7M7SsDX19CQL6sGngHjuj8hJXOjk=; b=PqE1Y/BKt5tlqXPF1d+Omy/URNnK+ftFSU5BLounWUJJ2wJ2UH2osBw/JNpXZ6weR3 HrEfR2hl/Uo5J2CkPzlDrxVqnm90iybN1rb0nk26QEFcWR/Krx+zmUXOouKJDIAfwNBr uS39yd1Z4GdBEkw8B81iqf+XNj7EYF2GtsZOKzFwg+8OFy2ukSvZ/HR2qamcaEwt5PkF i4sHJ2zckuf6OkmnOWhu9NXzVzVLtAgxIDP2GVPaIhuijo5cTBw3ig3Vj6V/2T6QIkBj VpIdAvnWyQgSWQMarbO0Zun9fodV4V2+V54Jvtd0iya/kQx5pcoQxwf3JI/GGBinj5R4 YQKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=X26Pc92X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c11si3114588ejs.396.2020.04.24.05.35.37; Fri, 24 Apr 2020 05:36:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=X26Pc92X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbgDXMb4 (ORCPT + 99 others); Fri, 24 Apr 2020 08:31:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:52528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727815AbgDXMXF (ORCPT ); Fri, 24 Apr 2020 08:23:05 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BEDA0215A4; Fri, 24 Apr 2020 12:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587730985; bh=nQ0Vf+165eGL0489SyYq0Q0g3F/aMxn/foENK0fy4/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X26Pc92XGus87kMSq+2ynamI2C+xV43gP6JjqCxLrkEs1tKBCzVG1bq2cgL2BFJI9 4buTCRyySyVZOUANFIFGnrmK5EkvlKB33lnDMDZ9Wd2GbTzn1/bzb6reF5TG+476vm 1TAlY/HvnMYRQyPH1WpcN5xKhl00e06bkAO0LyPw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jason Gunthorpe , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.6 24/38] net/cxgb4: Check the return from t4_query_params properly Date: Fri, 24 Apr 2020 08:22:22 -0400 Message-Id: <20200424122237.9831-24-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200424122237.9831-1-sashal@kernel.org> References: <20200424122237.9831-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Gunthorpe [ Upstream commit c799fca8baf18d1bbbbad6c3b736eefbde8bdb90 ] Positive return values are also failures that don't set val, although this probably can't happen. Fixes gcc 10 warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_phy_fw_ver’: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3747:14: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] 3747 | *phy_fw_ver = val; Fixes: 01b6961410b7 ("cxgb4: Add PHY firmware support for T420-BT cards") Signed-off-by: Jason Gunthorpe Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 844fdcf55118b..2d4ed751333fe 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -3748,7 +3748,7 @@ int t4_phy_fw_ver(struct adapter *adap, int *phy_fw_ver) FW_PARAMS_PARAM_Z_V(FW_PARAMS_PARAM_DEV_PHYFW_VERSION)); ret = t4_query_params(adap, adap->mbox, adap->pf, 0, 1, ¶m, &val); - if (ret < 0) + if (ret) return ret; *phy_fw_ver = val; return 0; -- 2.20.1