Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Apr 2020 15:02:40 +0200
From:   Halil Pasic <pasic@linux.ibm.com>
To:     Cornelia Huck <cohuck@redhat.com>
Cc:     Jared Rossi <jrossi@linux.ibm.com>,
        Eric Farman <farman@linux.ibm.com>, linux-s390@vger.kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] vfio-ccw: Enable transparent CCW IPL from DASD
In-Reply-To: <20200420141317.4537498f.cohuck@redhat.com>
References: <20200417182939.11460-1-jrossi@linux.ibm.com>
        <20200417182939.11460-2-jrossi@linux.ibm.com>
        <20200420141317.4537498f.cohuck@redhat.com>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Message-Id: <20200424150240.6fdede81.pasic@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 20 Apr 2020 14:13:17 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> > Remove the explicit prefetch check when using vfio-ccw devices.
> > This check is not needed as all Linux channel programs are intended
> > to use prefetch and will be executed in the same way regardless.  
> 
> Hm... my understanding is that we have the reasonable expectation that
> our guests will always issue channel programs that work fine with
> prefetch even if the bit is not set in the orb (including CCW IPL, in
> the way it is implemented in the s390-ccw QEMU bios), and therefore
> this patch is just making things less complicated.

AFAIR the problem is not s390-ccw QEMU bios. We could easily fix that.
The practical problem is some channel programs generated by zipl that
simply fail to set the bit (although they could). That is a perfectly
legit thing to do, because the prefetch bit was originally about
performance.

Sorry I missed your mail, so complained about the same
issues.

Regards,
Halil