Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next v3 01/11] bridge: uapi: mrp: Add mrp attributes.
To:     Horatiu Vultur <horatiu.vultur@microchip.com>, davem@davemloft.net,
        jiri@resnulli.us, ivecera@redhat.com, kuba@kernel.org,
        roopa@cumulusnetworks.com, olteanv@gmail.com, andrew@lunn.ch,
        UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, bridge@lists.linux-foundation.org
References: <20200422161833.1123-1-horatiu.vultur@microchip.com>
 <20200422161833.1123-2-horatiu.vultur@microchip.com>
From:   Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Message-ID: <2969c2e1-2ed4-87fd-7053-f70a3f923567@cumulusnetworks.com>
Date:   Fri, 24 Apr 2020 16:11:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200422161833.1123-2-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22/04/2020 19:18, Horatiu Vultur wrote:
> Add new nested netlink attribute to configure the MRP. These attributes are used
> by the userspace to add/delete/configure MRP instances and by the kernel to
> notify the userspace when the MRP ring gets open/closed. MRP nested attribute
> has the following attributes:
> 
> IFLA_BRIDGE_MRP_INSTANCE - the parameter type is br_mrp_instance which contains
>   the instance id, and the ifindex of the two ports. The ports can't be part of
>   multiple instances. This is used to create/delete MRP instances.
> 
> IFLA_BRIDGE_MRP_PORT_STATE - the parameter type is u32. Which can be forwarding,
>   blocking or disabled.
> 
> IFLA_BRIDGE_MRP_PORT_ROLE - the parameter type is br_mrp_port_role which
>   contains the instance id and the role. The role can be primary or secondary.
> 
> IFLA_BRIDGE_MRP_RING_STATE - the parameter type is br_mrp_ring_state which
>   contains the instance id and the state. The state can be open or closed.
> 
> IFLA_BRIDGE_MRP_RING_ROLE - the parameter type is br_mrp_ring_role which
>   contains the instance id and the ring role. The role can be MRM or MRC.
> 
> IFLA_BRIDGE_MRP_START_TEST - the parameter type is br_mrp_start_test which
>   contains the instance id, the interval at which to send the MRP_Test frames,
>   how many test frames can be missed before declaring the ring open and the
>   period which represent for how long to send the test frames.
> 
> Also add the file include/uapi/linux/mrp_bridge.h which defines all the types
> used by MRP that are also needed by the userpace.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  include/uapi/linux/if_bridge.h  | 42 +++++++++++++++++
>  include/uapi/linux/if_ether.h   |  1 +
>  include/uapi/linux/mrp_bridge.h | 84 +++++++++++++++++++++++++++++++++
>  3 files changed, 127 insertions(+)
>  create mode 100644 include/uapi/linux/mrp_bridge.h
> 

Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>