Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Apr 2020 09:22:34 -0400
From:   Vincent Cheng <vincent.cheng.xh@renesas.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     richardcochran@gmail.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary
 comparison
Message-ID: <20200424132233.GA18127@renesas.com>
References: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1587732746-98057-1-git-send-email-yangyingliang@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from renesas.com (173.195.53.163) by BYAPR08CA0013.namprd08.prod.outlook.com (2603:10b6:a03:100::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Fri, 24 Apr 2020 13:22:43 +0000
X-Originating-IP: [173.195.53.163]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 5b10ff67-008d-4924-8c47-08d7e852930c
X-MS-TrafficTypeDiagnostic: TYAPR01MB2784:
X-Microsoft-Antispam-PRVS: <TYAPR01MB2784E6A125D52DE9BDCA427DD2D00@TYAPR01MB2784.jpnprd01.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-Forefront-PRVS: 03838E948C
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYAPR01MB4735.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(16526019)(4744005)(2616005)(81156014)(52116002)(26005)(1076003)(956004)(7696005)(316002)(86362001)(5660300002)(66946007)(8676002)(6666004)(55016002)(36756003)(4326008)(8886007)(478600001)(2906002)(66476007)(66556008)(186003)(8936002)(6916009)(33656002);DIR:OUT;SFP:1102;
Received-SPF: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SqxbuvjorV8nqcnMZPS+rZvry7uHKuBZ2+OId2H8sRnZEqr/Na1rO3B130pbPag5phUHk0xaCA5+ZEirYX4fqpKP3OfHPf9DmDLrgv5VqpWIfeMM3bqOnWgr32Wj1z4HOALEKh3YfQe/uneIcHDqgvHV/XexLH752sm/7B7CemkfTFaEFxfNF0VxM89gWXbUY3+uUyqPG0ARNGie3UO/PzLlBX9WJexjhQ7Wqb6pbsFGJujRMa7vSZdcGgN7r+SlP6bVMZs/Bpr/1MzxkDbhADoN3iWrRB390GWbnvEaDulBVoNJjhxTvFCO54pIyVQUehGJPtXpbri7sldaYTngrluEBDpTe1i4vnP9feRrWad5FZeCg3qmTJMHOzOYjgqYhy/exH8WXOupWqivuEWYFFNWws1umV7B1JapWvDEUBbqhaX0pZvtEZGqgPS9jVWM
X-MS-Exchange-AntiSpam-MessageData: ePf020sB+x459Va/FfI119tzBKB9XHX8RBGoD66b4ffWCuBW6DnC8JcxDsyYZwUuZ4ggi9o3K0B9Puh1fatMfpxT4F8gEJFrud1CrZcT14xlL5ef9VRPfHX/Yu/qtMYSIms6g0gLK13MSX4F+NPEMg==
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b10ff67-008d-4924-8c47-08d7e852930c
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2020 13:22:44.9958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UScd7w0AQ3zC007Qwbz/iEPlhw1aaV4t7cUxYjHb/RQq5kcerkciJayGIL5nBI6LTgbDCcO1l3Al4nuvZPVuXSknkdDtvyORd89Nd6MlKec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2784
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>Reported-by: Hulk Robot <hulkci@huawei.com>
>Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
>index 032e112..56aee4f 100644
>--- a/drivers/ptp/ptp_clockmatrix.c
>+++ b/drivers/ptp/ptp_clockmatrix.c
>@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
> 
> 			/* Page size 128, last 4 bytes of page skipped */
> 			if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>-			     || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>+			     || loaddr > 0xfb)
> 				continue;
> 
> 			err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));

Thank-you for the fix.

Reviewed-by: Vincent Cheng  <vincent.cheng.xh@renesas.com>