Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp636150ybz; Fri, 24 Apr 2020 06:48:59 -0700 (PDT) X-Google-Smtp-Source: APiQypII4r5J3hO8PRj4rKIsy3Yqb4n6ZVEIXCfp4DoHpdIup8Q+cnFBB+Hz+JO/3GVgwvtM2/KP X-Received: by 2002:a17:906:25cb:: with SMTP id n11mr7393143ejb.37.1587736139226; Fri, 24 Apr 2020 06:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587736139; cv=none; d=google.com; s=arc-20160816; b=SYgqAy7DOxTWlRo2O/km0HnavmwWhVvSW+8D9ivjdWvtRlPaBirhBHZnt3GpleEJ9M KAKOJD9Kh/ILCUb+m77KfxVYgKdX3PJeV0ONtLLF6glgCGz3vFvhwlIyucBbtNovfV0w lpKSQMwK6NI4TN3xWZOdCorgwmzdvknxScspOIgQkLruIF+d5N3BVFOeA5aVBZ2PXxD0 pia5DaFaI4TANw5v0dKbxHvJv0J5upEfdCAx9kDUAVLcq4tsKVLHjLHOQ6k5UsmRlphD aZ9FTuRgbYvnYUqy3rPrisshKNTo+2lmdPHwv+zXybJIn1zed06XHvuho5jiAtxC3Cjb UnyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=O2gU3d/HcZ1ah+D1+PGnZWU9YtSNukQlC8E0KgTo0yc=; b=roW4HFhYnO9MsccM/wD+cjP6vEblWG8HD+5vlmIlxzkuyBKorMqa3FeKvBF0ZWF63I Cv0tT2oRv7AhktK/f6qDSKtY3G0wrmCZdx6gwdN63poo/SxsoyYUMmeCtixxdn1S0rMT wblOyGmyj9JwQmGqRO8d4iUPuQyxlZg9OMYxT7OeiupSYZALiWUVckxndZJi3J8nanun o18cOH0ABni40MF5z9vvTbVMKevcTDCqXlTl3XjE4Z09TDvRpdUhUTC6BACnWX3wW4kD cwxoqVCrioLKfi1tdl3cekdLyfH949oMHIRMJmNaj6+Hy7Wo0223jaRkAX1JTf+T1oBd Cd2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s12si2774507edx.72.2020.04.24.06.48.35; Fri, 24 Apr 2020 06:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727863AbgDXNrO (ORCPT + 99 others); Fri, 24 Apr 2020 09:47:14 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3288 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726895AbgDXNrO (ORCPT ); Fri, 24 Apr 2020 09:47:14 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 368F1BF29C90C2F48167; Fri, 24 Apr 2020 21:47:05 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Fri, 24 Apr 2020 21:46:57 +0800 From: Zou Wei To: CC: , , , Zou Wei Subject: [PATCH -next] net/mlx4_core: Add missing iounmap() in error path Date: Fri, 24 Apr 2020 21:53:14 +0800 Message-ID: <1587736394-111502-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/crdump.c:200:2-8: ERROR: missing iounmap; ioremap on line 190 and execution via conditional on line 198 Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used") Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/ethernet/mellanox/mlx4/crdump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/crdump.c b/drivers/net/ethernet/mellanox/mlx4/crdump.c index 73eae80e..ac5468b 100644 --- a/drivers/net/ethernet/mellanox/mlx4/crdump.c +++ b/drivers/net/ethernet/mellanox/mlx4/crdump.c @@ -197,6 +197,7 @@ int mlx4_crdump_collect(struct mlx4_dev *dev) err = devlink_region_snapshot_id_get(devlink, &id); if (err) { mlx4_err(dev, "crdump: devlink get snapshot id err %d\n", err); + iounmap(cr_space); return err; } -- 2.6.2