Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 24 Apr 2020 09:48:22 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Zou Wei <zou_wei@huawei.com>
Cc:     <mingo@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] tracing: Make tracing_snapshot_instance_cond()
 static
Message-ID: <20200424094822.5ae268fb@gandalf.local.home>
In-Reply-To: <1587614905-48692-1-git-send-email-zou_wei@huawei.com>
References: <1587614905-48692-1-git-send-email-zou_wei@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 23 Apr 2020 12:08:25 +0800
Zou Wei <zou_wei@huawei.com> wrote:

> Fix the following sparse warning:
> 
> kernel/trace/trace.c:950:6: warning: symbol 'tracing_snapshot_instance_cond'
> was not declared. Should it be static?

Thanks, I'll add it to my queue.

-- Steve

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  kernel/trace/trace.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8d2b988..1424a89 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -947,7 +947,8 @@ int __trace_bputs(unsigned long ip, const char *str)
>  EXPORT_SYMBOL_GPL(__trace_bputs);
>  
>  #ifdef CONFIG_TRACER_SNAPSHOT
> -void tracing_snapshot_instance_cond(struct trace_array *tr, void *cond_data)
> +static void tracing_snapshot_instance_cond(struct trace_array *tr,
> +					   void *cond_data)
>  {
>  	struct tracer *tracer = tr->current_trace;
>  	unsigned long flags;